Extract TraitImplHeader in AST/HIR by camsteffen · Pull Request #144386 · rust-lang/rust

camsteffen · 2025-07-24T02:58:40Z

Several fields of Impl are only applicable when it's a trait impl. This moves those fields into a new struct that is only present for trait impls.

rustbot · 2025-07-24T02:58:48Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

camsteffen · 2025-07-24T03:27:58Z

HIR ty lowering was modified

I don't think that's true fwiw.

xizheyin · 2025-07-24T04:19:09Z

HIR ty lowering was modified

This means this PR change the code in compiler/rustc_hir_analysis/src/hir_ty_lowering/, e.g. https://github.com/rust-lang/rust/pull/144386/files#diff-ce4273e1e949bf3052de7a08466c4dad785890b24091122954541b615b0ba199

camsteffen · 2025-07-24T04:39:34Z

@rustbot author

rustbot · 2025-07-24T04:39:38Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

compiler/rustc_parse/messages.ftl

compiler/rustc_ast/src/ast.rs

fmease · 2025-07-24T15:52:07Z

I'll perf this due to the added indirection for impl "modifiers" + extra alloc + size changes.

@bors try @rust-timer queue

rust-bors · 2025-07-24T15:52:11Z

⌛ Trying commit c0c102d with merge 513dd2b…

To cancel the try build, run the command @bors try cancel.

Extract ImplOfTrait in AST/HIR

fmease

Unfortunately this PR can't proceed without T-lang involvement and crater. This restricts Rust's stable grammar which is a breaking change.

Moreover, speaking from my experience it's quite unlikely that T-lang will approve narrowing the grammar since the general tendency has been to relax the grammar.

compiler/rustc_parse/src/parser/item.rs

fmease · 2025-07-24T16:04:26Z

@bors try cancel

This is a technically a breaking change for what can be parsed in `#[cfg(false)]`.

camsteffen · 2025-08-11T22:07:24Z

@bors r=fmease

Thanks for reviewing!

bors · 2025-08-11T22:07:26Z

📌 Commit bf266dc has been approved by fmease

It is now in the queue for this repository.

Extract TraitImplHeader in AST/HIR Several fields of `Impl` are only applicable when it's a trait impl. This moves those fields into a new struct that is only present for trait impls.

Rollup of 15 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144386 (Extract TraitImplHeader in AST/HIR) - #144542 (Stabilize `sse4a` and `tbm` target features) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) r? `@ghost` `@rustbot` modify labels: rollup

Extract TraitImplHeader in AST/HIR Several fields of `Impl` are only applicable when it's a trait impl. This moves those fields into a new struct that is only present for trait impls.

Rollup of 14 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144210 (std: thread: Return error if setting thread stack size fails) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) r? `@ghost` `@rustbot` modify labels: rollup

Extract TraitImplHeader in AST/HIR Several fields of `Impl` are only applicable when it's a trait impl. This moves those fields into a new struct that is only present for trait impls.

Rollup of 17 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144210 (std: thread: Return error if setting thread stack size fails) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) - #145283 (Make I-miscompile imply I-prioritize) - #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) - #145283 (Make I-miscompile imply I-prioritize) - #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc) - #145292 (Fix a typo in range docs) r? `@ghost` `@rustbot` modify labels: rollup

camsteffen · 2025-08-12T22:04:36Z

I guess the perf improvement was a farce.

rustbot assigned SparrowLii Jul 24, 2025

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 24, 2025

xizheyin reviewed Jul 24, 2025

View reviewed changes

compiler/rustc_parse/messages.ftl Outdated Show resolved Hide resolved

fbstj reviewed Jul 24, 2025

View reviewed changes

compiler/rustc_ast/src/ast.rs Show resolved Hide resolved

camsteffen force-pushed the imploftrait branch from 2b8e50d to 221aefa Compare July 24, 2025 15:04

This comment has been minimized.

Sign in to view

camsteffen force-pushed the imploftrait branch from 221aefa to c0c102d Compare July 24, 2025 15:17

fmease reviewed Jul 24, 2025

View reviewed changes

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 24, 2025

Auto merge of #144386 - camsteffen:imploftrait, r=<try>

513dd2b

Extract ImplOfTrait in AST/HIR

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 24, 2025

This comment has been minimized.

Sign in to view

fmease requested changes Jul 24, 2025

View reviewed changes

compiler/rustc_parse/src/parser/item.rs Show resolved Hide resolved

camsteffen added 5 commits August 11, 2025 16:58

Factor out InherentImplCannotUnsafe

39c5d6d

Move trait impl modifier errors to parsing

fa73390

This is a technically a breaking change for what can be parsed in `#[cfg(false)]`.

Tweak trait modifier errors

3aa0ac0

Extract ast TraitImplHeader

5bc23ce

Propagate TraitImplHeader to hir

bf266dc

camsteffen force-pushed the imploftrait branch from ae4cbbf to bf266dc Compare August 11, 2025 22:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2025

fmease mentioned this pull request Aug 11, 2025

Rollup of 16 pull requests #145280

Closed

fmease mentioned this pull request Aug 12, 2025

Rollup of 15 pull requests #145281

Closed

fmease mentioned this pull request Aug 12, 2025

Rollup of 15 pull requests #145282

Closed

fmease mentioned this pull request Aug 12, 2025

Rollup of 14 pull requests #145285

Closed

Zalathar mentioned this pull request Aug 12, 2025

Rollup of 17 pull requests #145293

Closed

Zalathar mentioned this pull request Aug 12, 2025

Rollup of 17 pull requests #145300

Merged

bors closed this Aug 12, 2025

dtolnay mentioned this pull request Aug 13, 2025

Reject negative inherent impls dtolnay/syn#1881

Merged

Mark-Simulacrum mentioned this pull request Sep 25, 2025

Draft release notes for 1.91 #147010

Closed

Uh oh!

Conversation

camsteffen commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

rustbot commented Jul 24, 2025

Uh oh!

This comment has been minimized.

camsteffen commented Jul 24, 2025

Uh oh!

This comment has been minimized.

xizheyin commented Jul 24, 2025

Uh oh!

camsteffen commented Jul 24, 2025

Uh oh!

rustbot commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

fmease commented Jul 24, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 24, 2025

Uh oh!

This comment has been minimized.

fmease left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fmease commented Jul 24, 2025

Uh oh!

camsteffen commented Aug 11, 2025

Uh oh!

bors commented Aug 11, 2025

Uh oh!

camsteffen commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

camsteffen commented Jul 24, 2025 •

edited

Loading