Add new optional tidy check to check if ftl error messages are unused#147191
Closed
GuillaumeGomez wants to merge 3 commits intorust-lang:masterfrom
Closed
Add new optional tidy check to check if ftl error messages are unused#147191GuillaumeGomez wants to merge 3 commits intorust-lang:masterfrom
GuillaumeGomez wants to merge 3 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized recently while removing a rustdoc feature that error messages could be unused and we apparently had no checks for that. This PR fills this void.
There is one unresolved question (likely due to my ignorance rather than an actual issue): we have (a lot of) error message IDs that are actually not anywhere in
ftlfiles, likeattr_parsing_remove_neg_sugg. Is it expected or not?In any case, there were unused error message IDs so I removed them in this PR as well.
cc @davidtwco
r? @Kobzol