Skip to content

Comments

Add Command::get_resolved_envs#149362

Open
schneems wants to merge 1 commit intorust-lang:mainfrom
schneems:schneems/get_resolved_envs
Open

Add Command::get_resolved_envs#149362
schneems wants to merge 1 commit intorust-lang:mainfrom
schneems:schneems/get_resolved_envs

Conversation

@schneems
Copy link
Contributor

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

Discussed in:

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 26, 2025
@schneems schneems marked this pull request as ready for review November 26, 2025 23:42
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 031cd0b to 7e93561 Compare November 26, 2025 23:46
@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 7e93561 to 44f98ba Compare November 26, 2025 23:49
@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 44f98ba to 1567085 Compare November 26, 2025 23:50
@bors
Copy link
Collaborator

bors commented Nov 27, 2025

☔ The latest upstream changes (presumably #149368) made this pull request unmergeable. Please resolve the merge conflicts.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 1567085 to 674da7d Compare November 27, 2025 14:09
@rustbot

This comment has been minimized.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed (and commit squashed for that nit)

I also added a few unresolved questions to the tracking issue but I don't think they're blockers for merging the initial implementation.

View changes since this review

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2025
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 60f78b5 to f47b0bb Compare January 14, 2026 22:12
@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from f47b0bb to 7068d49 Compare February 20, 2026 17:07
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.
@schneems schneems force-pushed the schneems/get_resolved_envs branch from 7068d49 to 2c27368 Compare February 20, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants