try enabling `linker-messages` by default again by jyn514 · Pull Request #149937 · rust-lang/rust

jyn514 · 2025-12-13T00:39:20Z

Split out linker-info from linker-messages
Make linker-messages warn-by-default; keep linker-info deny-by-default

Helps with #136096.

saethlin · 2025-12-13T15:28:55Z

try enabling `linker-messages` by default again

rust-bors · 2025-12-13T17:45:35Z

☀️ Try build successful (CI)
Build commit: 58b1b3c (58b1b3c5342a414c161338871f8004258ccef2a7, parent: eb171a227f9e5de5d376b6edb56b174bc8235fb3)

saethlin · 2025-12-13T18:04:31Z

@craterbot build-only

craterbot · 2025-12-13T18:04:34Z

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

saethlin · 2025-12-13T18:07:18Z

@craterbot run mode=build-only

craterbot · 2025-12-13T18:07:36Z

👌 Experiment pr-149937 created and queued.
🤖 Automatically detected try build 58b1b3c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc `@jieyouxu` `@Oneirical`

don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ``@jieyouxu`` ``@Oneirical``

don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ```@jieyouxu``` ```@Oneirical```

Rollup merge of #149969 - jyn514:ibt, r=jieyouxu don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of #149937. cc ```@jieyouxu``` ```@Oneirical```

bors · 2025-12-15T08:28:55Z

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang/rust#149937. cc ```@jieyouxu``` ```@Oneirical```

craterbot · 2025-12-25T06:54:22Z

🚧 Experiment pr-149937 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-12-27T07:36:02Z

🎉 Experiment pr-149937 is completed!
📊 24 regressed and 5 fixed (758860 total)
📊 2582 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149937/retry-regressed-list.txt ↩

mati865 · 2026-02-18T09:57:58Z

@bors try jobs=dist-x86_64-llvm-mingw

I have noticed recently that Clang doesn't handle -nolibc argument on Windows, so we will have to ignore the error for now (I'll implement the fix for the next version), or disable Clang's unused-command-line-argument warnings.

The error:

warning: linker stderr: x86_64-w64-mingw32-clang: argument unused during compilation: '-nolibc' [-Wunused-command-line-argument]
  |
  = note: `#[warn(linker_messages)]` on by default

warning: `std` (lib) generated 1 warning

try enabling `linker-messages` by default again try-job: dist-x86_64-llvm-mingw

rust-bors · 2026-02-18T10:44:58Z

💔 Test for 75ce9fd failed: CI. Failed job:

try - dist-x86_64-llvm-mingw (web logs, enhanced plaintext logs)

tests/ui/linkage-attr/raw-dylib/elf/glibc-x86_64.rs

… r=petrochenkov Do no add -no-pie on Windows Windows binaries are always position independent and Clang warns when trying to enable or disable that: ``` ❯ clang hello.c -pie clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] ❯ clang hello.c -no-pie clang: warning: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument] ``` rust-lang#149937 will turn these warnings into build errors: ``` ❯ cargo rustc -- -D linker-messages Compiling hello v0.1.0 (E:\tmp\hello) error: linker stderr: x86_64-w64-mingw32-clang: argument unused during compilation: '-nolibc' [-Wunused-command-line-argument]␍ x86_64-w64-mingw32-clang: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]␍ | = note: requested on the command line with `-D linker-messages` error: could not compile `hello` (bin "hello") due to 1 previous error ```

Rollup merge of #152793 - mati865:disable-no-pie-on-windows, r=petrochenkov Do no add -no-pie on Windows Windows binaries are always position independent and Clang warns when trying to enable or disable that: ``` ❯ clang hello.c -pie clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] ❯ clang hello.c -no-pie clang: warning: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument] ``` #149937 will turn these warnings into build errors: ``` ❯ cargo rustc -- -D linker-messages Compiling hello v0.1.0 (E:\tmp\hello) error: linker stderr: x86_64-w64-mingw32-clang: argument unused during compilation: '-nolibc' [-Wunused-command-line-argument]␍ x86_64-w64-mingw32-clang: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]␍ | = note: requested on the command line with `-D linker-messages` error: could not compile `hello` (bin "hello") due to 1 previous error ```

- Hide common linker output behind `linker-info` - Add tests - Account for different capitalization on windows-gnu when removing "warning" prefix - Add some more comments - Add macOS deployment-target test - Ignore linker warnings from trying to statically link glibc I don't know what's going on in `nofile-limit.rs` but I want no part of it. - Use a fake linker so tests are platform-independent

It's an incomplete feature anyway, it's ok for it to be broken.

rustbot · 2026-02-19T16:36:25Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jyn514 · 2026-02-19T16:36:48Z

rebased this over #152793, the windows job should hopefully pass now.

mati865 · 2026-02-19T21:53:55Z

Perhaps I wasn't clear enough. There were two warnings with windows-gnullvm targets:

x86_64-w64-mingw32-clang: argument unused during compilation: '-nolibc' which occurs every time when linking and requires Clang fix: [Clang] [MinGW] Handle -nolibc argument llvm/llvm-project#182062
clang: warning: argument unused during compilation: '-no-pie' which used to occur when creating an executable and is solved by Do no add -no-pie on Windows #152793

Point 1. will still need to be handled until Clang's fix is generally available (may take years) or we change how rustc links mingw-w64 libs for windows-gnullvm.

…henkov Do no add -no-pie on Windows Windows binaries are always position independent and Clang warns when trying to enable or disable that: ``` ❯ clang hello.c -pie clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] ❯ clang hello.c -no-pie clang: warning: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument] ``` rust-lang/rust#149937 will turn these warnings into build errors: ``` ❯ cargo rustc -- -D linker-messages Compiling hello v0.1.0 (E:\tmp\hello) error: linker stderr: x86_64-w64-mingw32-clang: argument unused during compilation: '-nolibc' [-Wunused-command-line-argument]␍ x86_64-w64-mingw32-clang: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]␍ | = note: requested on the command line with `-D linker-messages` error: could not compile `hello` (bin "hello") due to 1 previous error ```

rust-bors · 2026-02-22T17:14:47Z

☔ The latest upstream changes (presumably #152965) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2026-02-23T01:37:34Z

I think it might make sense to merge all the changes except for the Allow -> Warn bump, so we can avoid merge conflicts.

mati865 · 2026-02-23T13:20:23Z

Yeah, sounds fine. Can't tell how many bugs are there yet to be uncovered,

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025