Skip to content

Comments

Use function shims to make sure EII works on apple targets#151733

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
jdonszelmann:eii-on-apple
Feb 19, 2026
Merged

Use function shims to make sure EII works on apple targets#151733
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
jdonszelmann:eii-on-apple

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jan 27, 2026

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: #146348 (comment)
Tracking issue: #125418

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2026
@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

ah that's the rebase's fault

@jdonszelmann
Copy link
Contributor Author

try build can still be interesting if the other test succeeds, but idk if we'll fail too fast, lemme rebase

@jdonszelmann jdonszelmann force-pushed the eii-on-apple branch 2 times, most recently from 14c4dda to 2fef4ab Compare January 27, 2026 12:17
@rustbot

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

@bors try cancel

@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

Try build cancelled. Cancelled workflows:

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

💔 Test for 8a39723 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

right, things are named differently, maybe we just shouldn't print that

@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

doesn't need the envvars anymore now, but let's just run the try build

@jdonszelmann
Copy link
Contributor Author

r? @bjorn3 (if you feel comfortable with this one?)

rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #149937 (try enabling `linker-messages` by default again)
 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152120 (Don't ICE on layout error in vtable computation)
 - #152419 (Move more query system code)
 - #152431 (Restrict the set of things that const stability can be applied to)
 - #152436 (Reenable a GCI+mGCA+GCPT test case)
 - #151142 (Support ADT types in type info reflection)
 - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2)
 - #152146 (mGCA: Add associated const type check)
 - #152372 (style: remove unneeded trailing commas)
 - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable)
 - #152397 (Update books)
 - #152441 (Fix typos and grammar in top-level and src/doc documentation)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2026
Use function shims to make sure EII works on apple targets

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: rust-lang#146348 (comment)
Tracking issue: rust-lang#125418
@matthiaskrgr
Copy link
Member

@bors r-
#152454 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple,test-various

rust-bors bot pushed a commit that referenced this pull request Feb 18, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
try-job: test-various
@rust-bors

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 18, 2026

💔 Test for 3ae07b9 failed: CI

@jdonszelmann
Copy link
Contributor Author

timeout?

@bors try jobs=aarch64-apple,test-various

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 18, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
try-job: test-various
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 19, 2026

☀️ Try build successful (CI)
Build commit: 85019dc (85019dc5f9a3aa4d02b81fb6c416eaa62a559b29, parent: c043085801b7a884054add21a94882216df5971c)

@jdonszelmann
Copy link
Contributor Author

@bors r=oli-obk

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 19, 2026

📌 Commit 91064bf has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 19, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152558 (rustc_expand: improve diagnostics for non-repeatable metavars in repetition)
 - #152596 (Make all multipart suggestions verbose)
 - #152815 (Add CURRENT_RUSTC_VERSION support for Clippy)
 - #152733 (Port #[rustc_doc_primitive] to the new attribute parser)
 - #152817 (Update enzyme submodule to match upstream)
 - #152819 (explicitly show behavior of <_>::assoc_fn)
 - #152823 (fix stale comments left over from ed3711e)
 - #152824 (Enable "View all comments" link feature in `triagebot.toml`)
@rust-bors rust-bors bot merged commit 46126ac into rust-lang:main Feb 19, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 19, 2026
rust-timer added a commit that referenced this pull request Feb 19, 2026
Rollup merge of #151733 - jdonszelmann:eii-on-apple, r=oli-obk

Use function shims to make sure EII works on apple targets

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: #146348 (comment)
Tracking issue: #125418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants