cleanup some more things in proc_macro::bridge#152166
Open
cyrgani wants to merge 6 commits intorust-lang:mainfrom
Open
cleanup some more things in proc_macro::bridge#152166cyrgani wants to merge 6 commits intorust-lang:mainfrom
proc_macro::bridge#152166cyrgani wants to merge 6 commits intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Feb 5, 2026
| ) -> Result<S::TokenStream, PanicMessage> | ||
| where | ||
| S: Server, | ||
| S::TokenStream: Default, |
Member
There was a problem hiding this comment.
Why does run_server actually return an Option<TokenStream> in the first place? Can't it return a TokenStream directly and if necessary create an empty TokenStream internally?
Contributor
Author
There was a problem hiding this comment.
I think it's needed because the crate-level TokenStream wraps the contained TokenStream handle in an Option to avoid using RPC for an empty TokenStream. I tried to remove it here and got use-after-free in proc_macro handle ICEs.
rust-cloud-vms
bot
force-pushed
the
questionable-pm-cleanups
branch
from
c1be145 to
74d2616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit should be reviewable on its own.