fix(macros): allow custom attributes on exported macros

[nyurik]

fixes #98291

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• People who recently interacted with files modified in this PR: compiler
• compiler expanded to 20 candidates
• Random selection from 12 candidates

[jieyouxu]

Maybe r? @petrochenkov

[petrochenkov]

This is not a correct change.
The point of macro_expanded_macro_exports_accessed_by_absolute_paths is to prohibit uses of #[macro_export] declarations produced by any macros/attributes going through name resolution, including tool attributes like #[rust_analyzer::macro_style].
Because before doing name resolution we don't know whether #[rust_analyzer::macro_style] is a tool attribute or a macro.

It's possible that the error can be relaxed in some cases, but doing that is involved, see links from the tracking issue (#144408) for more details.

[nyurik]

@petrochenkov Thanks for speedy review! At the moment, it is impossible to add a Could you give some further guidance on how #[clippy::format_args] can be allowed in the user code - what compiler changes could lead to supporting it? I would love to solve #98291, so any general guidance would be helpful.

[petrochenkov]

what compiler changes could lead to supporting it?

I don't know exactly, this needs some investigation by an expert (i.e. me :D).
Probably moving #[macro_export] declarations to a separate Scope, at least partially?
Probably some changes in resolve_ident_in_module_(non_)globs_unadjusted to process determinacy for #[macro_export] declarations more precisely?
Moving the macro_expanded_macro_exports_accessed_by_absolute_paths error to maybe_push_ambiguity.

[nyurik]

@petrochenkov thx, AI suggested this change 71dc761...nyurik:rust:bug-150518 (just in case it might help you), but I will wait for the expert investigation :)