Remove flaky test tests/rustdoc-gui/search-filter.goml to unbreak CI#152198
Closed
Zalathar wants to merge 1 commit intorust-lang:mainfrom
Closed
Remove flaky test tests/rustdoc-gui/search-filter.goml to unbreak CI#152198Zalathar wants to merge 1 commit intorust-lang:mainfrom
tests/rustdoc-gui/search-filter.goml to unbreak CI#152198Zalathar wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in GUI tests. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @notriddle rustbot has assigned @notriddle. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
Member
Author
|
Oh I found the Zulip thread at https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20failure.20because.20.60tests.2Frustdoc-gui.2Fsearch-filter.2Egoml.60/with/572282496 ; I'll see what's going on there before deciding what to do with this PR. |
Member
Author
|
Closing because #152194 already exists. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tests/rustdoc-guitests have had some flakiness problems, and this particular one has failed enough times recently to justify closing the tree in #152185 (comment).That's severe enough that I think we should rip it out ASAP to unbreak CI.