Skip to content

Comments

Port #[feature] to the new attribute system#152985

Open
JonathanBrouwer wants to merge 3 commits intorust-lang:mainfrom
JonathanBrouwer:convert-feature
Open

Port #[feature] to the new attribute system#152985
JonathanBrouwer wants to merge 3 commits intorust-lang:mainfrom
JonathanBrouwer:convert-feature

Conversation

@JonathanBrouwer
Copy link
Contributor

Rebase of #146652

Co-authored-by: jdonszelmann <janabent@gmail.com>
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors try jobs=x86_64-rust-for-linux

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
Port `#[feature]` to the new attribute system


try-job: x86_64-rust-for-linux
@rust-log-analyzer

This comment has been minimized.

Co-authored-by: jdonszelmann <janabent@gmail.com>
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 22, 2026

💔 Test for b70562e failed: CI. Failed job:

@JonathanBrouwer
Copy link
Contributor Author

@bors try jobs=x86_64-rust-for-linux

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
Port `#[feature]` to the new attribute system


try-job: x86_64-rust-for-linux
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 22, 2026

☀️ Try build successful (CI)
Build commit: 179eec7 (179eec7ca4685ae98d2f815dc7371f517ff1ee52, parent: 1500f0f47f5fe8ddcd6528f6c6c031b210b4eac5)

@JonathanBrouwer
Copy link
Contributor Author

r? @jdonszelmann

@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 22, 2026 20:20
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 22, 2026
@jdonszelmann
Copy link
Contributor

Fixed by rust-lang/rust-clippy#15678

@bors r_

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 23, 2026

Unknown command "r_". Run @bors help to see available commands.

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 23, 2026

📌 Commit 0b52901 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 23, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants