Do not attempt to evaluate obligations on PointeeSized goals#153100
Open
KiChjang wants to merge 1 commit intorust-lang:mainfrom
Open
Do not attempt to evaluate obligations on PointeeSized goals#153100KiChjang wants to merge 1 commit intorust-lang:mainfrom
KiChjang wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
b40bc12 to
01292d0
Compare
Contributor
Author
|
r? @rperier since you have left comments in an earlier PR |
Collaborator
|
Failed to set assignee to
|
Contributor
Author
Contributor
|
Note: #151962 already exists |
Contributor
|
Yeah, I am not a reviewer. I have just wrote the original feature (reporting similarly named traits) :) Could you sync with the author of #151962, or co-author the fix with him perhaps, as there was already a PR opened for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151957.
In this PR, we simply special-case the fulfillment goal if the goal is
PointeeSized, since the trait itself isn't lowered to the trait solver, and all types implement it.