interpreter error reporting: remove arguments that are always the same#153613
Open
RalfJung wants to merge 2 commits intorust-lang:mainfrom
Open
interpreter error reporting: remove arguments that are always the same#153613RalfJung wants to merge 2 commits intorust-lang:mainfrom
RalfJung wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| ) | ||
| crate::const_eval::report(ecx, error, move |diag, span, frames| { | ||
| // FIXME(oli-obk): figure out how to use structured diagnostics again. | ||
| diag.code(E0080); |
Contributor
There was a problem hiding this comment.
the error code is also shared by both invocations - might be nice to put in report
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Member
Author
|
Makes sense! I then found some more opportunities for cleanups. :) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
interpret-report
branch
from
f146f67 to
46e3c4d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
reportfunction is called twice and both callers use the samespanandget_span_and_frames... so let's just fix those arguments inside the function, no need to be more generic than this.