Skip to content

add test that an incomplete feature emits a warning#153736

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cyrgani:incomplete-2
Mar 12, 2026
Merged

add test that an incomplete feature emits a warning#153736
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cyrgani:incomplete-2

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 11, 2026

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the incomplete_features lint. (since this seemed to be the favored approach on Zulip)

Alternative to #153706.

r? fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2026
@@ -0,0 +1,13 @@
//! Make sure that incomplete features emit the `incomplete_features` lint.

// gate-test-test_incomplete_feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously not your usual feature gate test (where #[feature] is absent) but that's fine since there's no real alternative.

@fmease
Copy link
Member

fmease commented Mar 12, 2026

Thanks! @bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 12, 2026

📌 Commit c909ae5 has been approved by fmease

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
add test that an incomplete feature emits a warning

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the `incomplete_features` lint. (since this seemed to be the favored approach on Zulip)

Alternative to rust-lang#153706.

r? fmease
rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 4 pull requests

Successful merges:

 - #153432 (Fix some comments about dataflow analysis.)
 - #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
 - #153736 (add test that an incomplete feature emits a warning)
 - #153750 (rustc-dev-guide subtree update)
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 12, 2026

⌛ Testing commit c909ae5 with merge f5b423f...

Workflow: https://github.com/rust-lang/rust/actions/runs/22986427226

rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
add test that an incomplete feature emits a warning

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the `incomplete_features` lint. (since this seemed to be the favored approach on Zulip)

Alternative to #153706.

r? fmease
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
add test that an incomplete feature emits a warning

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the `incomplete_features` lint. (since this seemed to be the favored approach on Zulip)

Alternative to rust-lang#153706.

r? fmease
@Zalathar
Copy link
Member

x86_64-gnu-aux job looks stalled.

@bors yield

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 12, 2026

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153761.

rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 7 pull requests

Successful merges:

 - #153736 (add test that an incomplete feature emits a warning)
 - #153160 (Fix relative extern URL depth on source pages)
 - #153432 (Fix some comments about dataflow analysis.)
 - #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
 - #153717 (unused_macro_rules switched used and unused comments)
 - #153748 (editorconfig: css uses tabs)
 - #153750 (rustc-dev-guide subtree update)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
add test that an incomplete feature emits a warning

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the `incomplete_features` lint. (since this seemed to be the favored approach on Zulip)

Alternative to rust-lang#153706.

r? fmease
rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests

Successful merges:

 - #153726 (Add optional CI job to build the compiler with the parallel frontend)
 - #153763 (Don't add empty target features for target-cpu=native on macOS)
 - #153432 (Fix some comments about dataflow analysis.)
 - #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
 - #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
 - #153708 (de-non_const `Iterator` trait methods)
 - #153717 (unused_macro_rules switched used and unused comments)
 - #153736 (add test that an incomplete feature emits a warning)
 - #153748 (editorconfig: css uses tabs)
 - #153750 (rustc-dev-guide subtree update)
 - #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
add test that an incomplete feature emits a warning

Related to rust-lang/compiler-team#974, this PR adds a new test to specifically check that a dummy incomplete feature triggers the `incomplete_features` lint. (since this seemed to be the favored approach on Zulip)

Alternative to rust-lang#153706.

r? fmease
rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #153726 (Add optional CI job to build the compiler with the parallel frontend)
 - #153763 (Don't add empty target features for target-cpu=native on macOS)
 - #153432 (Fix some comments about dataflow analysis.)
 - #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
 - #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
 - #153717 (unused_macro_rules switched used and unused comments)
 - #153736 (add test that an incomplete feature emits a warning)
 - #153748 (editorconfig: css uses tabs)
 - #153750 (rustc-dev-guide subtree update)
 - #153762 (actually make the is-fn test test what it says it tests)
@rust-bors rust-bors bot merged commit 82017d9 into rust-lang:main Mar 12, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 12, 2026
@cyrgani cyrgani deleted the incomplete-2 branch March 12, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants