Rollup of 5 pull requests by JonathanBrouwer · Pull Request #153783 · rust-lang/rust

JonathanBrouwer · 2026-03-12T14:52:13Z

Successful merges:

Always generate generics in delegation that match trait in trait impl scenario #153705 (Always generate generics in delegation that match trait in trait impl scenario)
Detect existing turbofish on method calls to suppress useless suggestion #153751 (Detect existing turbofish on method calls to suppress useless suggestion)
Remove MTLock #153780 (Remove MTLock)
Fix Hexagon ABI calling convention for small aggregates #151572 (Fix Hexagon ABI calling convention for small aggregates)
Fix that ./x test --no-doc actually keeps the same behaviour for backwards compatability #153725 (Fix that ./x test --no-doc actually keeps the same behaviour for backwards compatability)

Small structs (<= 64 bits) were being passed with their fields split into separate arguments instead of being packed into register-sized chunks. This caused ABI mismatches. The fix properly casts small aggregates to consecutive register-sized chunks using Uniform::consecutive(), matching the Hexagon C ABI where small structs are packed into R1:0 register pair. This fixes tests like extern-pass-TwoU16s.rs and extern-pass-TwoU8s.rs.

Correct the handling of aggregate types in extern "C" functions to match the Hexagon ABI specification: - Aggregates up to 32 bits: passed/returned in a single register (R0) - Aggregates 33-64 bits: passed/returned in a register pair (R1:R0) - Aggregates > 64 bits: passed on stack via byval, returned via sret This fixes all tests/ui/abi/extern/ tests for Hexagon, including: - extern-pass-TwoU8s, extern-pass-TwoU16s, extern-pass-TwoU32s - extern-pass-TwoU64s, extern-pass-FiveU16s - extern-return-TwoU8s, extern-return-TwoU16s, extern-return-TwoU32s - extern-return-TwoU64s, extern-return-FiveU16s

…ckwards compatability

@petrochenkov

…nerics, r=petrochenkov Always generate generics in delegation that match trait in trait impl scenario After rust-lang#151864 there is a change in delegation code generation in `trait impl` cases: after rust-lang#151864 we started to look at user-specified args and generate functions, whose generics may not match the signature of the function that is defined in trait. Such handling of delegation from trait impl is not correct, as the generated function should always have the same generics as its signature function in trait. This addresses the "Fix generic params generation in trait impl case" future work from rust-lang#151864 r? @petrochenkov

@eggyal

…stion, r=lcnr Detect existing turbofish on method calls to suppress useless suggestion `expr_inferred_arg_iter` hardcoded `have_turbofish: false` for `MethodCall` expressions, while the `Path` case properly checked for existing type arguments via `segment.args`. This meant the "consider specifying the generic arguments" suggestion always fired on method calls, even when the user already had a turbofish, producing a suggestion that just rewrote user syntax into fully qualified form without resolving anything. Fixes rust-lang#153732. cc @eggyal

Remove `MTLock` This removes the `MTLock` type and replaces it users with the regular `Lock`. It no longer makes sense now that we don't have a compile-time toggle for parallelism.

…ywiser Fix Hexagon ABI calling convention for small aggregates Small structs (<= 64 bits) were being passed with their fields split into separate arguments instead of being packed into register-sized chunks. This caused ABI mismatches. The fix properly casts small aggregates to consecutive register-sized chunks using Uniform::consecutive(), matching the Hexagon C ABI where small structs are packed into R1:0 register pair. This fixes tests like extern-pass-TwoU16s.rs and extern-pass-TwoU8s.rs.

@Kobzol

…Kobzol Fix that `./x test --no-doc` actually keeps the same behaviour for backwards compatability In rust-lang#153143 the `./x test --no-doc` flag was renamed to `--all-targets`. I added a commit that keeps the `--no-doc` flag for backwards compatibility, but unfortunately I forgot to actually keep the behaviour the same, which is fixed by this PR. r? @Kobzol

JonathanBrouwer · 2026-03-12T14:52:26Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-12T14:52:29Z

📌 Commit 8088898 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-03-12T18:20:14Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 26m 23s
Pushing 801bc19 to main...

github-actions · 2026-03-12T18:23:23Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d097a0c (parent) -> 801bc19 (this PR)

Test differences

Show 9 test diffs

Stage 1

[ui] tests/ui/delegation/generics/impl-trait-wrong-args-count.rs: pass -> [missing] (J0)
[ui] tests/ui/delegation/generics/trait-impl-wrong-args-count.rs: [missing] -> pass (J0)
[ui] tests/ui/inference/useless-turbofish-suggestion.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/delegation/generics/impl-trait-wrong-args-count.rs: pass -> [missing] (J1)
[ui] tests/ui/delegation/generics/trait-impl-wrong-args-count.rs: [missing] -> pass (J1)
[ui] tests/ui/inference/useless-turbofish-suggestion.rs: [missing] -> pass (J1)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 801bc19d6089fed18b1ffa2f496d154da30f7a18 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 1h 55m -> 2h 27m (+28.6%)
dist-apple-various: 1h 59m -> 1h 37m (-18.2%)
x86_64-gnu-llvm-20: 1h 6m -> 1h 17m (+15.7%)
x86_64-gnu-miri: 1h 20m -> 1h 32m (+15.4%)
pr-check-1: 28m 18s -> 32m 38s (+15.3%)
x86_64-gnu-tools: 56m 2s -> 1h 2m (+11.0%)
x86_64-gnu-debug: 1h 57m -> 2h 9m (+10.3%)
aarch64-gnu-llvm-20-2: 46m 38s -> 50m 58s (+9.3%)
dist-ohos-armv7: 1h 12m -> 1h 18m (+9.1%)
i686-msvc-1: 2h 58m -> 3h 13m (+8.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-12T19:01:49Z

Finished benchmarking commit (801bc19): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	10.2%	[10.2%, 10.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-3.7%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[-3.7%, 10.2%]	3

Cycles

Results (primary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[1.9%, 2.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[1.9%, 2.9%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.456s -> 479.193s (-0.47%)
Artifact size: 394.96 MiB -> 394.87 MiB (-0.02%)

androm3da and others added 12 commits January 23, 2026 23:46

Detect existing turbofish on method calls to suppress useless suggestion

4d47b07

Fix that ./x test --no-doc actually keeps the same behaviour for ba…

675290a

…ckwards compatability

Bless issue-23041 test after turbofish suggestion suppression

6e954d3

Remove MTLock

bee28ef

Always generate generics that match trait in trait impl scenario

d87d7b9

Rollup merge of rust-lang#153780 - Zoxc:rm-mtlock, r=bjorn3

6385535

Remove `MTLock` This removes the `MTLock` type and replaces it users with the regular `Lock`. It no longer makes sense now that we don't have a compile-time toggle for parallelism.

rust-bors bot added the rollup A PR which is a rollup label Mar 12, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 12, 2026

rust-bors bot mentioned this pull request Mar 12, 2026

Always generate generics in delegation that match trait in trait impl scenario #153705

Merged

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2026

rust-bors bot merged commit 801bc19 into rust-lang:main Mar 12, 2026
12 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2026

rustbot added this to the 1.96.0 milestone Mar 12, 2026

rust-bors bot mentioned this pull request Mar 12, 2026

ty-aware delayed AST -> HIR lowering #153489

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#153783

Rollup of 5 pull requests#153783
rust-bors[bot] merged 12 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-xAG0lwn

JonathanBrouwer commented Mar 12, 2026

Uh oh!

JonathanBrouwer commented Mar 12, 2026

Uh oh!

rust-bors bot commented Mar 12, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 12, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented Mar 12, 2026

Uh oh!

JonathanBrouwer commented Mar 12, 2026

Uh oh!

rust-bors bot commented Mar 12, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 12, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 12, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants