rustdoc: preserve `doc(cfg)` on locally re-exported type aliases by shivendra02467 · Pull Request #154970 · rust-lang/rust

shivendra02467 · 2026-04-07T22:03:39Z

When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its cfg attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the cfg badge (unlike structs or enums), the portability info is lost entirely.

This patch explicitly preserves the target's cfg metadata when the generated item is a TypeAliasItem, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior.

Fixes #154921

rustbot · 2026-04-07T22:03:45Z

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, camelid, fmease, lolbinarycat, notriddle

GuillaumeGomez · 2026-04-15T17:01:26Z

Thanks!

@bors r+ rollup

rust-bors · 2026-04-15T17:04:14Z

📌 Commit 617d9de has been approved by GuillaumeGomez

It is now in the queue for this repository.

… r=GuillaumeGomez rustdoc: preserve `doc(cfg)` on locally re-exported type aliases When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior. Fixes rust-lang#154921

Rollup of 6 pull requests Successful merges: - #147811 (naked functions: respect `function-sections`) - #154599 (report the `varargs_without_pattern` lint in deps) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes)

… r=GuillaumeGomez rustdoc: preserve `doc(cfg)` on locally re-exported type aliases When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior. Fixes rust-lang#154921

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

jhpratt · 2026-04-16T05:53:23Z

@bors r-

#155373 (comment)

rust-bors · 2026-04-16T05:53:30Z

This pull request was unapproved.

This PR was contained in a rollup (#155373), which was unapproved.

When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior.

shivendra02467 · 2026-04-16T06:26:19Z

Fixed a cross-platform test failure on macOS by switching target_os to a custom feature flag.
@rustbot ready

GuillaumeGomez · 2026-04-16T13:56:26Z

Didn't think about the cfg in the test, my bad. The updated code looks good so let's go again. Thanks!

@bors r+ rollup

rust-bors · 2026-04-16T13:56:30Z

📌 Commit 52ad8c0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

… r=GuillaumeGomez rustdoc: preserve `doc(cfg)` on locally re-exported type aliases When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior. Fixes rust-lang#154921

Rollup of 13 pull requests Successful merges: - #152980 (c-variadic: fix implementation on `avr`) - #154491 (Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug)) - #155354 (Remove AttributeSafety from BUILTIN_ATTRIBUTES) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155095 (changed the information provided by (mut x) to mut x (Fix 155030)) - #155358 (ImproperCTypes: Move erasing_region_normalisation into helper function) - #155377 (tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs) - #155383 (Rearrange `rustc_ast_pretty`) - #155384 (triagebot: notify on diagnostic attribute changes) - #155386 (Use `box_new` diagnostic item for Box::new suggestions) - #155391 (Small refactor of `QueryJob::latch` method) - #155395 (Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc) - #155396 (`as_ref_unchecked` docs link fix)

… r=GuillaumeGomez rustdoc: preserve `doc(cfg)` on locally re-exported type aliases When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior. Fixes rust-lang#154921

Rollup of 19 pull requests Successful merges: - #141633 (Suggest to bind `self.x` to `x` when field `x` may be in format string) - #152980 (c-variadic: fix implementation on `avr`) - #154491 (Extend `core::char`'s documentation of casing issues (and fix a rustdoc bug)) - #155318 (Use mutable pointers for Unix path buffers) - #155335 (Bump bootstrap to 1.96 beta) - #155354 (Remove AttributeSafety from BUILTIN_ATTRIBUTES) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155095 (changed the information provided by (mut x) to mut x (Fix 155030)) - #155305 (Make `convert_while_ascii` unsafe) - #155358 (ImproperCTypes: Move erasing_region_normalisation into helper function) - #155377 (tests/debuginfo/basic-stepping.rs: Remove FIXME related to ZSTs) - #155383 (Rearrange `rustc_ast_pretty`) - #155384 (triagebot: notify on diagnostic attribute changes) - #155386 (Use `box_new` diagnostic item for Box::new suggestions) - #155391 (Small refactor of `QueryJob::latch` method) - #155395 (Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc) - #155396 (`as_ref_unchecked` docs link fix) - #155411 (compiletest: Remove the `//@ should-ice` directive) - #155413 (fix: typo in `std::fs::hard_link` documentation)

rustbot assigned notriddle Apr 7, 2026

GuillaumeGomez approved these changes Apr 15, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2026

matthiaskrgr mentioned this pull request Apr 15, 2026

Rollup of 6 pull requests #155350

Closed

jhpratt mentioned this pull request Apr 16, 2026

Rollup of 18 pull requests #155373

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026

shivendra02467 force-pushed the fix-rustdoc-154921 branch from 617d9de to 52ad8c0 Compare April 16, 2026 06:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2026

GuillaumeGomez approved these changes Apr 16, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

JonathanBrouwer mentioned this pull request Apr 16, 2026

Rollup of 15 pull requests #155398

Closed

JonathanBrouwer mentioned this pull request Apr 16, 2026

Rollup of 14 pull requests #155401

Closed

GuillaumeGomez mentioned this pull request Apr 16, 2026

Rollup of 13 pull requests #155407

Closed

Zalathar mentioned this pull request Apr 17, 2026

Rollup of 19 pull requests #155416

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustdoc: preserve `doc(cfg)` on locally re-exported type aliases#154970

rustdoc: preserve `doc(cfg)` on locally re-exported type aliases#154970
shivendra02467 wants to merge 1 commit intorust-lang:mainfrom
shivendra02467:fix-rustdoc-154921

shivendra02467 commented Apr 7, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Apr 7, 2026

Uh oh!

GuillaumeGomez commented Apr 15, 2026

Uh oh!

rust-bors bot commented Apr 15, 2026

Uh oh!

jhpratt commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

shivendra02467 commented Apr 16, 2026

Uh oh!

GuillaumeGomez commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

shivendra02467 commented Apr 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 7, 2026

Uh oh!

GuillaumeGomez commented Apr 15, 2026

Uh oh!

rust-bors bot commented Apr 15, 2026

Uh oh!

jhpratt commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

shivendra02467 commented Apr 16, 2026

Uh oh!

GuillaumeGomez commented Apr 16, 2026

Uh oh!

rust-bors bot commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shivendra02467 commented Apr 7, 2026 •

edited by rustbot

Loading