Skip to content

Move tests from tests/ui/issues/ to appropriate directories#155062

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:reorg-tests
Apr 13, 2026
Merged

Move tests from tests/ui/issues/ to appropriate directories#155062
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:reorg-tests

Conversation

@ujjwalvishwakarma2006
Copy link
Copy Markdown
Contributor

@ujjwalvishwakarma2006 ujjwalvishwakarma2006 commented Apr 9, 2026 •
edited
Loading

In this PR, I am moving the following test from tests/ui/issues directory to the appropriate directories, followed by the addition of issue links at the top and reblessing of the stderr files:

old-name new-sub-dir new-name
issue-29516.rs auto-traits/ distinct-type-tuple-by-negative-impl.rs
issue-3874.rs binding/ ref-in-let-lhs-in-field.rs
issue-32782.rs feature-gates/ feature-gate-check-nested-macro-invocation.rs
issue-32782.stderr feature-gates/ feature-gate-check-nested-macro-invocation.stderr
issue-5100.rs pattern/ match-errors-derived-error-suppression.rs
issue-5100.stderr pattern/ match-errors-derived-error-suppression.stderr
issue-21033.rs pattern/ match-struct-var-having-boxed-field.rs

r? Kivooeo
r? Teapot4195

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026
@ujjwalvishwakarma2006 ujjwalvishwakarma2006 changed the title Reorg tests Move tests from tests/ui/issues/ to appropriate directories Apr 9, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 10, 2026

Both of this are ui/pattern tests, they testing a patterns not Box semantics

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 10, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 10, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ujjwalvishwakarma2006
Copy link
Copy Markdown
Contributor Author

ujjwalvishwakarma2006 commented Apr 10, 2026 •
edited
Loading

Both of this are ui/pattern tests, they testing a patterns not Box semantics

  1. I thought the same for the first file, but the description of tests/ui/box in the README.md file here says to include pattern matching involving the unstable box_pattern feature in the box directory.

Tests for Box<T> smart pointer and #![feature(box_patterns)]. E.g. allocation, deref coercion, and edge cases in box pattern matching and placement.

I understand that ultimately this feature will become stable, and it will then make sense to put it into the tests/ui/pattern directory.

  1. After reading the issue and the fix PR, to me, it looks like something was wrong with the type checker that was fixed. More specifically, something like derived errors was being shown to the user for the test case. That shouldn't happen. That's why I chose the filename as match errors when derived errors are suppressed.

Oh, wait. I think I put a no in the file name. I will correct it. ( :

@ujjwalvishwakarma2006 ujjwalvishwakarma2006 mentioned this pull request Apr 11, 2026
Closed
@ujjwalvishwakarma2006
Copy link
Copy Markdown
Contributor Author

ujjwalvishwakarma2006 commented Apr 12, 2026 •
edited
Loading

I have closed PR#155058 with the latest commit and made the suggested changes.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 13, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 13, 2026

📌 Commit 9de8c8c has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#155062 - ujjwalvishwakarma2006:reorg-tests,…
0e264ba 
… r=Kivooeo

Move tests from `tests/ui/issues/` to appropriate directories

In this PR, I am moving the following test from `tests/ui/issues` directory to the appropriate directories, followed by the addition of issue links at the top and reblessing of the stderr files:

| old-name | new-sub-dir | new-name |
|-|-|-|
| `issue-29516.rs` | `auto-traits/` | `distinct-type-tuple-by-negative-impl.rs` |
| `issue-3874.rs` | `binding/` | `ref-in-let-lhs-in-field.rs` |
| `issue-32782.rs` | `feature-gates/` | `feature-gate-check-nested-macro-invocation.rs` |
| `issue-32782.stderr` | `feature-gates/` | `feature-gate-check-nested-macro-invocation.stderr` |
| `issue-5100.rs` | `pattern/` | `match-errors-derived-error-suppression.rs` |
| `issue-5100.stderr` | `pattern/` | `match-errors-derived-error-suppression.stderr` |
| `issue-21033.rs` | `pattern/` | `match-struct-var-having-boxed-field.rs` |

r? Kivooeo
r? Teapot4195
This was referenced Apr 13, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 13, 2026
@bors
Auto merge of #155253 - JonathanBrouwer:rollup-lERdTAB, r=JonathanBro…
17584a1 
…uwer

Rollup of 19 pull requests

Successful merges:

 - #155162 (relnotes for 1.95)
 - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`)
 - #153604 (Fix thread::available_parallelism on WASI targets with threads)
 - #154193 (Implement EII for statics)
 - #154389 (Add more robust handling of nested query cycles)
 - #154435 (resolve: Some import resolution cleanups)
 - #155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`)
 - #155243 (cg_ssa: transmute between scalable vectors)
 - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable)
 - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests)
 - #154624 (Make `DerefPure` dyn-incompatible)
 - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`)
 - #154944 (Small refactor of `arena_cache` query values)
 - #155055 (UI automation)
 - #155062 (Move tests from `tests/ui/issues/` to appropriate directories)
 - #155131 (Stabilize feature `uint_bit_width`)
 - #155147 (Stabilize feature `int_lowest_highest_one`)
 - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)
 - #155194 (Fix manpage version replacement and use verbose version)
@rust-bors rust-bors bot merged commit b8e88c7 into rust-lang:main Apr 13, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 13, 2026
rust-timer added a commit that referenced this pull request Apr 13, 2026
@rust-timer
Unrolled build for #155062
ff937bd 
Rollup merge of #155062 - ujjwalvishwakarma2006:reorg-tests, r=Kivooeo

Move tests from `tests/ui/issues/` to appropriate directories

In this PR, I am moving the following test from `tests/ui/issues` directory to the appropriate directories, followed by the addition of issue links at the top and reblessing of the stderr files:

| old-name | new-sub-dir | new-name |
|-|-|-|
| `issue-29516.rs` | `auto-traits/` | `distinct-type-tuple-by-negative-impl.rs` |
| `issue-3874.rs` | `binding/` | `ref-in-let-lhs-in-field.rs` |
| `issue-32782.rs` | `feature-gates/` | `feature-gate-check-nested-macro-invocation.rs` |
| `issue-32782.stderr` | `feature-gates/` | `feature-gate-check-nested-macro-invocation.stderr` |
| `issue-5100.rs` | `pattern/` | `match-errors-derived-error-suppression.rs` |
| `issue-5100.stderr` | `pattern/` | `match-errors-derived-error-suppression.stderr` |
| `issue-21033.rs` | `pattern/` | `match-struct-var-having-boxed-field.rs` |

r? Kivooeo
r? Teapot4195
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 13, 2026
@bors
Auto merge of #155253 - JonathanBrouwer:rollup-lERdTAB, r=JonathanBro…
ec71ad7 
…uwer

Rollup of 19 pull requests

Successful merges:

 - rust-lang/rust#155162 (relnotes for 1.95)
 - rust-lang/rust#140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`)
 - rust-lang/rust#153604 (Fix thread::available_parallelism on WASI targets with threads)
 - rust-lang/rust#154193 (Implement EII for statics)
 - rust-lang/rust#154389 (Add more robust handling of nested query cycles)
 - rust-lang/rust#154435 (resolve: Some import resolution cleanups)
 - rust-lang/rust#155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`)
 - rust-lang/rust#155243 (cg_ssa: transmute between scalable vectors)
 - rust-lang/rust#153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable)
 - rust-lang/rust#154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests)
 - rust-lang/rust#154624 (Make `DerefPure` dyn-incompatible)
 - rust-lang/rust#154929 (Add `const Default` impls for `LazyCell` and `LazyLock`)
 - rust-lang/rust#154944 (Small refactor of `arena_cache` query values)
 - rust-lang/rust#155055 (UI automation)
 - rust-lang/rust#155062 (Move tests from `tests/ui/issues/` to appropriate directories)
 - rust-lang/rust#155131 (Stabilize feature `uint_bit_width`)
 - rust-lang/rust#155147 (Stabilize feature `int_lowest_highest_one`)
 - rust-lang/rust#155174 (Improve emission of `UnknownDiagnosticAttribute` lint)
 - rust-lang/rust#155194 (Fix manpage version replacement and use verbose version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ujjwalvishwakarma2006 @Kivooeo @rustbot