Fix ICE in span_extend_prev_while with multibyte characters#155068
Open
lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Open
Fix ICE in span_extend_prev_while with multibyte characters#155068lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
span_extend_prev_while with multibyte characters#155068lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
lapla-cogito
force-pushed
the
multibyte_char
branch
from
25347d8 to
c7afad0
Compare
lapla-cogito
force-pushed
the
multibyte_char
branch
from
c7afad0 to
2754a83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155037
The function assumed that the character found by
rfindwas always one byte wide, using a hardcoded1instead ofc.len_utf8(). When a multibyte character appeared immediately before the span, this caused the resulting span to point into the middle of a UTF-8 sequence, triggering an assertion failure inbytepos_to_file_charpos.