Allow manual Unpin impls for local extern types#155069
Closed
officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
Closed
Allow manual Unpin impls for local extern types#155069officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Closing as the user has been banned |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows explicit
Unpinimpls for localextern types underpin_ergonomics.#[pin_v2]only applies to ADTs with Rust-visible fields, so local foreign types do not need the structurally pinned rejection path. Before this change, that path hit a delayed bug and ICEd on code likeimpl Unpin for ExternType {}.Fixes #155053.