Avoid mir_const_qualif ICE for invalid const trait methods#155070
Avoid mir_const_qualif ICE for invalid const trait methods#155070officialasishkumar wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Hi, For the last few months we have been receiving an increased amount of slop by users running bots that generate contributions, and even misconfiguring their bot so it will even send generated apology emails on top. We have no way to distinguish your PR from your hundreds other recently generated ones and no way to determine whether you actually want to contribute. We are a community of contributors, not just a code repository. Thus we focus on contributors who desire to stay around and put in the work to produce high quality contributions or learn to do so. We are thus banning you as per our policies (1) and contribution standards (2). You can contact the moderation team to discuss and possibly reconsider your ban. Thanks for understanding Oli in the name of the mod team |
This switches MIR const-qualification gating to use the body's actual const context instead of raw item constness for functions, associated functions, and closures.
That avoids calling
mir_const_qualiffor closures nested inside invalidconst fntrait methods, which previously ICEd after emitting E0379. Added a regression test.Fixes #153891.