Rollup of 3 pull requests#155163
Closed
JonathanBrouwer wants to merge 7 commits intorust-lang:mainfrom
Closed
Conversation
The recently-added test currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target. Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
… r=Mark-Simulacrum Update libc to v0.2.184 This includes the WASI _SC_* sysconf constants needed for `thread::available_parallelism` on WASI targets (rust-lang#153604).
…ock-max-test, r=Mark-Simulacrum Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7 The test recently added in rust-lang#153555 currently systematically deadlocks when running it under i686 Windows 7, but not x86_64 that passes it fine. This therefore fixes the test for the target. Empirically, the correct value for `MAX_READERS` seems to be `2^28 - 1`: removing the `- 1` re-introduces the deadlock, at least under our testing environment. This fix thus uses this value. However, I have no real justification to support that, because I find myself a bit at a loss when comparing the implementation details, the comment added above the test and what the current value is; some help would therefore be nice in this aspect. Also, the value change is restricted to 32-bit Win7 as there is no evidence to support it should be done for other targets. cc @roblabla @rustbot label O-windows-msvc O-windows-7 O-x86_32 A-atomic T-libs
…, r=Mark-Simulacrum Make Box/Rc/Arc::into_array allocator-aware (and add doctest) Tracking issue for `alloc_slice_into_array`: rust-lang#148082 Tracking issue for `allocator_api`: rust-lang#32838 Make the `into_array` methods on `Box`, `Rc`, and `Arc` allocator-aware. I think the allocator-aware-ness should not be observable on stable, so these should not be additionally (comment-)gated behind `feature(allocator_api)`, just like e.g. `Box::leak` and `Vec::into_boxed_slice`. The added doctests do not use `feature(allocator_api)`. @rustbot label T-libs-api
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
test_rwlock_max_readersfor x86 Win7 #154967 (Test(lib/sync): Fixtest_rwlock_max_readersfor x86 Win7)r? @ghost
Create a similar rollup