Skip to content

#[rustc_must_match_exhaustively] detect let else#155276

Open
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
jdonszelmann:must-match-exhaustively-let-else
Open

#[rustc_must_match_exhaustively] detect let else#155276
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
jdonszelmann:must-match-exhaustively-let-else

Conversation

@jdonszelmann
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann commented Apr 14, 2026

Extension of #155047, I forgor to lint on let-else :3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@jdonszelmann
Copy link
Copy Markdown
Contributor Author

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned dingxiangfei2009 Apr 14, 2026
@jdonszelmann jdonszelmann changed the title Must match exhaustively let else #[rustc_must_match_exhaustively] detect let else Apr 14, 2026
@jdonszelmann jdonszelmann force-pushed the must-match-exhaustively-let-else branch from 948ad33 to 26a0fdc Compare April 14, 2026 09:06
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

📌 Commit 26a0fdc has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…ly-let-else, r=JonathanBrouwer

`#[rustc_must_match_exhaustively]` detect let else

Extension of rust-lang#155047, I forgor to lint on let-else :3
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…ly-let-else, r=JonathanBrouwer

`#[rustc_must_match_exhaustively]` detect let else

Extension of rust-lang#155047, I forgor to lint on let-else :3
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…ly-let-else, r=JonathanBrouwer

`#[rustc_must_match_exhaustively]` detect let else

Extension of rust-lang#155047, I forgor to lint on let-else :3
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…ly-let-else, r=JonathanBrouwer

`#[rustc_must_match_exhaustively]` detect let else

Extension of rust-lang#155047, I forgor to lint on let-else :3
rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #154049 (delegation: Track more precise spans for glob delegations)
 - #155134 (Replace custom trim_ascii_start with the standard library method)
 - #155235 (add the `fma4` x86 target feature)
 - #155218 (coroutines: Skip the closure signature annotation check for tainted bodies)
 - #155274 (limit duplicate-profiler-builtins test to targets that can do dynamic linking)
 - #155276 (`#[rustc_must_match_exhaustively]` detect let else)
 - #155281 (Revert "allow `windows-gnu` targets to embed gdb visualizer scripts")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants