diagnostics: suggest generic_const_args for const ops#156968
Open
Dnreikronos wants to merge 1 commit into
Open
diagnostics: suggest generic_const_args for const ops#156968Dnreikronos wants to merge 1 commit into
Dnreikronos wants to merge 1 commit into
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Dnreikronos
force-pushed
the
fix/gca-const-item-diagnostic-156729
branch
4 times, most recently
from
a43c40b to
d890018
Compare
This comment has been minimized.
This comment has been minimized.
Dnreikronos
force-pushed
the
fix/gca-const-item-diagnostic-156729
branch
from
d890018 to
f883d0e
Compare
This comment has been minimized.
This comment has been minimized.
Dnreikronos
force-pushed
the
fix/gca-const-item-diagnostic-156729
branch
from
f883d0e to
a9b91d1
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@wesleywiser, hi! |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
…stics Point users at `#![feature(generic_const_args)]` and `type const` items when they hit the "generic parameters may not be used in const operations" error, not just `generic_const_exprs`.
Dnreikronos
force-pushed
the
fix/gca-const-item-diagnostic-156729
branch
from
c02ce98 to
bf4bad2
Compare
rustbot
removed
S-waiting-on-author
Dnreikronos
changed the title
generic_const_args + type const items in const operation diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #156729
when const ops hit generic params, like
[u8; size_of::<self>()], the diagnostic only points atgeneric_const_exprs. imo that's a stale nudge now thatgeneric_const_argsandtype constitems are the path we want people trying.add help for
generic_const_argsandtype constitems in the resolve and hir_ty_lowering paths. also skip the old gce suggestion oncemin_generic_const_argsis enabled, and emit both suggestions for theselfalias path so the "alternatively" wording doesn't hang there by itself. includes the regression test from the issue. lgtm.