Stop using dlltool for generating import libraries on MinGW#157712
Open
bjorn3 wants to merge 1 commit into
Open
Stop using dlltool for generating import libraries on MinGW#157712bjorn3 wants to merge 1 commit into
bjorn3 wants to merge 1 commit into
Conversation
rustbot
added
A-compiletest
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
064b8e5 to
b5d891b
Compare
rustbot
added
the
T-rust-analyzer
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
b5d891b to
a17a3d2
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
a17a3d2 to
3cbb918
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
3cbb918 to
adca83a
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
adca83a to
4fa01bb
Compare
This comment has been minimized.
This comment has been minimized.
Older versions of ld.bfd didn't support short import libraries like the builtin implementation of rustc generates. So we worked around this by using binutils dlltool, which produces the old import library format. We have now bumped the minimum supported ld.bfd version to one which does support them, so we can drop the dlltool usage. This makes cross-compilation a bit easier and removes a bunch of code in rustc.
bjorn3
force-pushed
the
remove_dlltool_usage
branch
from
4fa01bb to
238a0fd
Compare
Collaborator
|
These commits modify compiler targets. Some changes occurred in src/tools/compiletest cc @jieyouxu
|
rustbot
added
S-waiting-on-review
Member
Author
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
cc @mati865 |
Member
|
I think the consensus on Zulip was that we want to hold back the breaking changes until next release after the bump. To give the time for updating. |
Member
Well, they did but with caveats. Like, it broke when import libs were put inside archive like staticlib/rlib. |
Member
Author
|
My bad. Let's wait for beta to branch then. @rustbot author |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of ld.bfd didn't support short import libraries like the builtin implementation of rustc generates. So we worked around this by using binutils dlltool, which produces the old import library format. We have now bumped (TODO) the minimum supported ld.bfd version to one which does support them, so we can drop the dlltool usage. This makes cross-compilation a bit easier and removes a bunch of code in rustc.
Blocked on updating the required binutils version.