fix binding const argument to assoc type suggestion#157908
Open
Kivooeo wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
fmease
reviewed
Jun 15, 2026
Comment on lines
+1022
to
+1026
| .filter(|(potential, item)| match potential { | ||
| hir::GenericArg::Const(_) => item.is_type_const(), | ||
| hir::GenericArg::Type(_) => item.is_type(), | ||
| _ => false, | ||
| }) |
Member
There was a problem hiding this comment.
... this check assumes that the type & const arguments magically line up with the associated types & consts, respectively, which doesn't hold up in reality IINM because the unbound_assoc_items (unbound_types) come in definition order.
What I'm saying is that your code probably emits a suggestion here:
trait Trait { type A; type const B: usize; }
fn f<T: Trait<(), 0>>(); // your PR emits a suggestionbut not here:
trait Trait { type const A: usize; type B; }
fn f<T: Trait<(), 0>>(); // your PR does *not* emit a suggestion IINMbecause "[(TyAssocConst, Ty), (AssocTy, Const)]" doesn't contain any matches according to the filter.
fmease
added
S-waiting-on-author
fmease
reviewed
Jun 15, 2026
Member
Author
|
it seems like i've addressed all reviews, but not sure @rustbot ready |
rustbot
removed
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-review
rust-cloud-vms
Bot
force-pushed
the
fix-mgca-assoc-sugg
branch
from
d1c91a7 to
d0c3c77
Compare
fmease
reviewed
Jun 15, 2026
Member
Author
|
are you fine if i will stack commits on top of each other while review is going, but i will squash them later before merge, just to make it easier to follow what's changed after every push? |
Member
|
You can already squash / fix up / amend everything as you go, I'm gonna use the View changes since this review link in #157908 (review) which is sufficient for this patch. Anyway, r=me with suggestions applied @bors rollup |
rust-cloud-vms
Bot
force-pushed
the
fix-mgca-assoc-sugg
branch
from
d0c3c77 to
8aa97c0
Compare
Kivooeo
commented
Jun 15, 2026
Comment on lines
+17
to
+23
| error[E0107]: trait takes 0 generic arguments but 1 generic argument was supplied | ||
| --> $DIR/use-type-argument-instead-of-assoc-type.rs:11:17 | ||
| | | ||
| LL | fn take(_: impl Iterator<0>) {} | ||
| | ^^^^^^^^ expected 0 generic arguments | ||
|
|
||
| error: aborting due to 2 previous errors |
Member
Author
There was a problem hiding this comment.
here is new test, i've extended existed test with it
rust-cloud-vms
Bot
force-pushed
the
fix-mgca-assoc-sugg
branch
from
8aa97c0 to
c1f6331
Compare
Member
Author
|
@bors r=fmease rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 15, 2026
fix binding const argument to assoc type suggestion r? fmease fixes rust-lang#151602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
r? fmease
fixes #151602