Allow the unstable attribute on foreign type by kantnero · Pull Request #158233 · rust-lang/rust

kantnero · 2026-06-22T00:20:47Z

While working the FnPtr trait in #156176 @carbotaniuman was trying to implement Code as an extern type but got an error as the current stability infrastructure does not allow unstable attribute on foreign type. #158200

This PR fixes that by allowing the unstable attribute on ForeignTy and adds test to verify.

@rustbot r? @JonathanBrouwer

rustbot · 2026-06-22T00:20:50Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-06-22T00:20:52Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JonathanBrouwer (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2026-06-22T16:09:30Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

kantnero · 2026-06-26T22:17:48Z

@rustbot ready

JonathanBrouwer

Looks like the uitests need to be blessed, looks good to me after that, thanks <3

View changes since this review

kantnero · 2026-06-27T15:32:45Z

@JonathanBrouwer Done running --bless. Should I push the updated .stderr file as well?

JonathanBrouwer · 2026-06-27T15:44:19Z

@kantnero Yes, the stderr file contains the expected output from the test, which you are intentionally changing.
See https://rustc-dev-guide.rust-lang.org/tests/running.html#editing-and-updating-the-reference-files for more information

Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

kantnero · 2026-06-27T16:10:52Z

@JonathanBrouwer Done thanks

JonathanBrouwer · 2026-06-27T16:42:54Z

@bors r+ rollup
Thanks a lot!

rust-bors · 2026-06-27T16:42:57Z

📌 Commit 94888f0 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@carbotaniuman

…rget, r=JonathanBrouwer Allow the unstable attribute on foreign type While working the `FnPtr` trait in rust-lang#156176 @carbotaniuman was trying to implement `Code` as an extern type but got an error as the current stability infrastructure does not allow `unstable` attribute on foreign type. rust-lang#158200 This PR fixes that by allowing the `unstable` attribute on ForeignTy and adds test to verify. @rustbot r? @JonathanBrouwer

…uwer Rollup of 4 pull requests Successful merges: - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #158233 (Allow the unstable attribute on foreign type) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

@carbotaniuman

…rget, r=JonathanBrouwer Allow the unstable attribute on foreign type While working the `FnPtr` trait in rust-lang#156176 @carbotaniuman was trying to implement `Code` as an extern type but got an error as the current stability infrastructure does not allow `unstable` attribute on foreign type. rust-lang#158200 This PR fixes that by allowing the `unstable` attribute on ForeignTy and adds test to verify. @rustbot r? @JonathanBrouwer

…uwer Rollup of 6 pull requests Successful merges: - #158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #158163 (Fix too-short variance slice in `variances_of` cycle recovery) - #158233 (Allow the unstable attribute on foreign type) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

JonathanBrouwer · 2026-06-27T20:47:09Z

@bors try jobs=x86_64-gnu-llvm-22-3

rust-bors · 2026-06-27T20:47:17Z

⌛ Trying commit 94888f0 with merge a211074…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/28301348660

Allow the unstable attribute on foreign type try-job: x86_64-gnu-llvm-22-3

…uwer Rollup of 6 pull requests Successful merges: - #158194 (Adds RmetaLinkCache a per-link cache that uses path as the key of dec…) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #158163 (Fix too-short variance slice in `variances_of` cycle recovery) - #158233 (Allow the unstable attribute on foreign type) - #158470 (Upgrade `jsonsocck` and `jsondoclint` to edition 2024.) - #158488 (Upgrade `rustdoc-json-types` to 2024 edition.)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2026

rustbot assigned JonathanBrouwer Jun 22, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer reviewed Jun 22, 2026

View reviewed changes

Comment thread tests/ui/stability-attribute/foreign-type-stability.rs Outdated

JonathanBrouwer requested changes Jun 22, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2026

kantnero force-pushed the allow-unstable-attr-on-target branch from b915a1c to 4b98d4c Compare June 22, 2026 17:25

kantnero requested a review from JonathanBrouwer June 22, 2026 17:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2026

kantnero marked this pull request as draft June 22, 2026 17:46

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2026

Allow unstable attribute on foreign types and add stability test

b973eb9

kantnero force-pushed the allow-unstable-attr-on-target branch from 8fd861c to b973eb9 Compare June 22, 2026 18:03

This comment has been minimized.

Sign in to view

Add test to confirm usage of unstable foreign type error

2592b41

Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

kantnero marked this pull request as ready for review June 26, 2026 21:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer requested changes Jun 27, 2026

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 27, 2026

update bless output

94888f0

Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

kantnero requested a review from JonathanBrouwer June 27, 2026 16:10

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2026

JonathanBrouwer mentioned this pull request Jun 27, 2026

Rollup of 4 pull requests #158493

Closed

JonathanBrouwer mentioned this pull request Jun 27, 2026

Rollup of 6 pull requests #158498

Open

rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026

Auto merge of #158233 - kantnero:allow-unstable-attr-on-target, r=<try>

a211074

Allow the unstable attribute on foreign type try-job: x86_64-gnu-llvm-22-3

Uh oh!

Uh oh!

Conversation

kantnero commented Jun 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

This comment has been minimized.

kantnero commented Jun 26, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kantnero commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 27, 2026

Uh oh!

kantnero commented Jun 27, 2026

Uh oh!

JonathanBrouwer commented Jun 27, 2026

Uh oh!

rust-bors Bot commented Jun 27, 2026

Uh oh!

JonathanBrouwer commented Jun 27, 2026

Uh oh!

rust-bors Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kantnero commented Jun 22, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

kantnero commented Jun 27, 2026 •

edited

Loading

rust-bors Bot commented Jun 27, 2026 •

edited

Loading