Move check_target_feature into the attribute parser#158313
Open
obeis wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Use `TargetFeatureParser` to reject `#[target_feature]` on functions marked as lang items (via `#[lang = "..."]` or `#[panic_handler]`), replacing `check_target_feature` in `rustc_passes`.
obeis
force-pushed
the
move-check_target_feature
branch
from
9881ee7 to
284b9e1
Compare
Contributor
|
☔ The latest upstream changes (presumably #158342) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
JonathanBrouwer
requested changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Could you make the same change here as in #158361?
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
| // except on WASM where calling target-feature functions is safe (see #84988). | ||
| if matches!( | ||
| cx.target, | ||
| Target::Fn | Target::Method(MethodKind::Trait { body: true } | MethodKind::Inherent) |
Contributor
There was a problem hiding this comment.
I wonder why we need to check the target here. Is there any test that fails if you remove this condition, if so, could you add a comment in the code with the reason this check is needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #153101
Use
TargetFeatureParserto reject#[target_feature]on functions marked as lang items (via#[lang = "..."]or#[panic_handler]), replacingcheck_target_featureinrustc_passes.r? @JonathanBrouwer