Clippy subtree update by flip1995 · Pull Request #158403 · rust-lang/rust

flip1995 · 2026-06-25T14:38:18Z

r? Manishearth

…t suggestion When suggesting `sort_by_key` for a reversed comparator like `|a, b| b.foo.cmp(&a.foo)`, the lint was picking `left_expr` (the receiver of `.cmp()`, which references `b`) and `r_pat` as the closure arg, producing `|b| Reverse(b.foo)`. Both sides consistently named `b`, but `b` is the second parameter — confusing and inconsistent with the forward-sort suggestion style. Fix by using `right_expr` (the `.cmp()` argument, which references `a`) as the key body and `l_pat` as the closure parameter, peeling the single `&` that `.cmp(&rhs)` introduces so the suggestion doesn't contain a spurious borrow.

The choice of `std::env::current_dir` made me originally think this was about file and directory paths - use an item where "path" couldn't mean something else. `std::f64::consts::PI` was chosen to match the example.

This lint suggests using `as_chunks` or `as_chunks_mut` instead of `chunks_exact` or `chunks_exact_mut` when called with a constant size. changelog: new lint: [`chunks_exact_to_as_chunks`]

update test comments

An explicit type annotation on the LHS (`let _: T = expr`) signals an intentional discard, mirroring the rationale for `let_underscore_untyped`. Without this gate, typed bindings such as `let _: Pin<Box<dyn Future<Output = ()>>> = foo();` trigger the lint despite the author explicitly opting in. changelog: [`let_underscore_future`]: no longer triggers when the binding has an explicit type annotation Signed-off-by: ChrisJr404 <chris@hacknow.com>

…y_kind_from_def_id and new_from_def_id

@BoxyUwU

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

…ubtree-update

*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17042)* changelog: [`by_ref_peekable_peek`]: new lint Closes rust-lang/rust-clippy#17020

…on PhantomPinned

Instead of bailing, this changes the lint to handle the return type and write out the correct result. If the function we're translating into can handle it, we use a turbofish, since that will influence type inference but not cause integer truncation. But, if that can't be done, it'll use `as` and let a future lint take care of that.

…s allowed

| crate | instructions base | instructions new | delta | |---|---|---|---| | cargo-0.80.0 (lib) | 29,893,214,650 | 29,726,591,660 | -0.56% | | cargo-0.80.0 (bin) | 1,631,825,989 | 1,627,901,224 | -0.24% | | serde-1.0.204 | 7,203,901,010 | 7,167,022,578 | -0.51% | | tokio-1.38.1 | 522,611,594 | 518,512,971 | -0.78% | | ryu-1.0.18 | 271,073,171 | 270,569,049 | -0.19% | changelog: none

…lints

…_refs

…lint

- make the comments more specific and useful - add return-type ascription even if there are params that still prevent this from being a machine applicable lint

…s allowed (rust-lang#17217) Instruction counts (perf stat instructions:u): | crate | instructions base | instructions new | delta | |---|---|---|---| | regex-1.10.5 | 1,010,565,235 | 968,595,926 | -4.15% | | bumpalo-3.16.0 | 320,518,375 | 313,577,464 | -2.17% | | tokio-1.38.1 | 522,405,496 | 510,949,744 | -2.19% | | mdbook-0.4.40 (bin) | 3,475,263,547 | 3,466,707,439 | -0.25% | | ripgrep-14.1.0 | 1,969,387,093 | 1,957,903,931 | -0.58% | changelog: none

rustbot · 2026-06-25T16:50:57Z

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

flip1995 · 2026-06-25T16:51:53Z

I don't think this suggestion will make people happy

Nvm. With this suggestion applied, I could remove a arr.try_into().unwrap(). IMO this version is an improvement. But YMMV. So @antoyo , please take a look before we merge this: 6c335ef

antoyo · 2026-06-25T17:24:02Z

Nvm. With this suggestion applied, I could remove a arr.try_into().unwrap(). IMO this version is an improvement. But YMMV. So @antoyo , please take a look before we merge this: 6c335ef

I guess this was already an issue before, but could you please add a debug_assert to make sure the remainder is empty?
Looks good to me otherwise.

Manishearth · 2026-06-25T18:16:08Z

@bors r+ p=2 rollup=never

rust-bors · 2026-06-25T18:16:12Z

📌 Commit 6c335ef has been approved by Manishearth

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 6. This pull request will be tested once the tree is reopened.

Manishearth · 2026-06-25T18:16:40Z

@bors r-

r=me after the suggestion is implemented

rust-bors · 2026-06-25T18:16:45Z

This pull request was unapproved.

View changes since this unapproval

flip1995 · 2026-06-25T18:20:49Z

I guess this was already an issue before, but could you please add a debug_assert to make sure the remainder is empty?

Sure, can do. But that is already guaranteed by the match bytes.len(). Still want me to add the debug_assert?

antoyo · 2026-06-25T18:23:41Z

Sure, can do. But that is already guaranteed by the match bytes.len(). Still want me to add the debug_assert?

Yes please.

flip1995 · 2026-06-26T08:34:31Z

I amended it to 91c04df, PTAL.

Manishearth · 2026-06-26T10:48:16Z

@bors r+ p=2

rust-bors · 2026-06-26T10:48:19Z

📌 Commit 91c04df has been approved by Manishearth

It is now in the queue for this repository.

rust-bors · 2026-06-26T14:17:18Z

☀️ Test successful - CI
Approved by: Manishearth
Duration: 3h 22m 52s
Pushing eb6346c to main...

github-actions · 2026-06-26T14:20:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 40557f6 (parent) -> eb6346c (this PR)

Test differences

Show 3 test diffs

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard eb6346c659ccb0468a1477c716ca5450a1fa9ba1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 25m 43s -> 9m 1s (-64.9%)
x86_64-rust-for-linux: 1h 7m -> 28m 8s (-58.2%)
dist-i686-mingw: 2h 3m -> 2h 55m (+41.9%)
dist-powerpc64-linux-musl: 1h 6m -> 1h 31m (+37.4%)
pr-check-1: 44m 3s -> 29m 13s (-33.7%)
pr-check-2: 50m 57s -> 35m 16s (-30.8%)
dist-x86_64-freebsd: 1h 42m -> 1h 11m (-30.5%)
x86_64-gnu-tools: 1h 20m -> 57m 28s (-28.6%)
x86_64-gnu-next-trait-solver-polonius: 1h 15m -> 55m 28s (-27.0%)
x86_64-gnu-gcc: 1h 30m -> 1h 6m (-26.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-26T15:13:31Z

Finished benchmarking commit (eb6346c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.8%, secondary -5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-5.0%	[-5.0%, -5.0%]	1
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 482.935s -> 485.381s (0.51%)
Artifact size: 392.98 MiB -> 392.99 MiB (0.00%)

laffed and others added 30 commits April 16, 2026 14:01

fix: [manual_slice_fill] detect for in loops over &mut [T; n] slices

f6a921c

absolute_paths.rs: change item in "What it does" example

a259d0a

The choice of `std::env::current_dir` made me originally think this was about file and directory paths - use an item where "path" couldn't mean something else. `std::f64::consts::PI` was chosen to match the example.

Avoid map_unwrap_or fix when default is adjusted

9fc79b2

Add new chunks_exact_to_as_chunks lint

fbb4036

This lint suggests using `as_chunks` or `as_chunks_mut` instead of `chunks_exact` or `chunks_exact_mut` when called with a constant size. changelog: new lint: [`chunks_exact_to_as_chunks`]

add skip lint when is_ty_unified is true.

8710368

update test comments

remove multiple calls to expr_use_ctxt

74ad9b6

Attributes cleanup in tests [12/20]

029b8d2

refactor TypeRelativePath::AssocItem to use AliasTerm, remove alias_t…

6c8aae7

…y_kind_from_def_id and new_from_def_id

Remove unused is_type_const from hir::TraitItemKind

c60910b

Rollup merge of rust-lang#157330 - josetorrs:remove-is-type-const, r=…

a945bdf

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

New by_ref_peekable_peek lint

2ae1735

Merge commit '5f29bd0df789f92cd494061f9223dbb5d96e8e16' into clippy-s…

85daf6e

…ubtree-update

New by_ref_peekable_peek lint (rust-lang#17042)

824aa1f

*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17042)* changelog: [`by_ref_peekable_peek`]: new lint Closes rust-lang/rust-clippy#17020

remove AliasTerm::def_id()

6ccea6c

Refactor drain_collect and clarify the lint messages.

5076a6b

Replace is_range_full with is_full_collection_range.

a71d118

Added PhantomPinned diagnostic item and prevented dead field warning …

372057a

…on PhantomPinned

perf: skip doc_markdown text collection and word scan when the lint i…

934018e

…s allowed

perf: check is_in_test last in incompatible_msrv

51844e3

perf: check the token kind before extracting source in early literal …

81c4ee5

…lints

perf: match expression shape before MSRV check in cloned_ref_to_slice…

aa783f1

…_refs

perf: compare method names before type queries in three lint passes

75b49df

perf: check the method name first in or_fun_call

49bb992

perf: skip single_component_path_imports module walk when nothing to …

a972a88

…lint

Address nits

2027f8a

- make the comments more specific and useful - add return-type ascription even if there are params that still prevent this from being a machine applicable lint

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2026

cg_gcc: Fix Clippy lint fallout

91c04df

flip1995 force-pushed the clippy-subtree-update branch from 6c335ef to 91c04df Compare June 26, 2026 08:33

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

rust-bors Bot merged commit eb6346c into rust-lang:main Jun 26, 2026
14 checks passed

rustbot added this to the 1.98.0 milestone Jun 26, 2026

This was referenced Jun 26, 2026

More lint cleanups #158431

Open

rustdoc: do not include extra stuff in span #157561

Open

Uh oh!

Uh oh!

Conversation

flip1995 commented Jun 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 25, 2026

Uh oh!

flip1995 commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoyo commented Jun 25, 2026

Uh oh!

Manishearth commented Jun 25, 2026

Uh oh!

rust-bors Bot commented Jun 25, 2026

Uh oh!

Manishearth commented Jun 25, 2026

Uh oh!

rust-bors Bot commented Jun 25, 2026

Uh oh!

flip1995 commented Jun 25, 2026

Uh oh!

antoyo commented Jun 25, 2026

Uh oh!

flip1995 commented Jun 26, 2026

Uh oh!

Manishearth commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Test differences

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 26, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

flip1995 commented Jun 25, 2026 •

edited by rustbot

Loading

flip1995 commented Jun 25, 2026 •

edited

Loading