Rollup of 6 pull requests by JonathanBrouwer · Pull Request #158437 · rust-lang/rust

JonathanBrouwer · 2026-06-26T09:28:36Z

Successful merges:

Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children)
cg_LLVM: Stop needing an alloca for volatile loads #157127 (cg_LLVM: Stop needing an alloca for volatile loads)
Attribute docs deprecated , warn, allow, cfg, deny, and forbid #158244 (Attribute docs deprecated , warn, allow, cfg, deny, and forbid )
Fixup the refactoring errors in #156246 #158355 (Fixup the refactoring errors in Introduce a RerunNonErased error type mirroring NoSolution, to better track when we're bailing #156246)
std: truncate thread names on NetBSD #158399 (std: truncate thread names on NetBSD)
Guard clone suggestion against empty obligation errors #158430 (Guard clone suggestion against empty obligation errors)

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

…ame as their parent

…rbid` * Added documentation for allow, cfg, deny, forbid, deprecated and warn attribute Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix typo Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback and add link to rustc book Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

@ghost

Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children Various things I noticed while figuring out how to best allow changing some borrowck errors into FCWs cc @rust-lang/types for the typeck children stuff, in case I missed some memo and am undoing some work r? @ghost need perf first

@nikic

…ve, r=nikic cg_LLVM: Stop needing an alloca for volatile loads This ended up also being reimplementing it to not use `load` of the `llvm_type`, since without doing that everything blew up horribly. cc the zulip conversation [#t-opsem > Defining volatile splitting @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Defining.20volatile.20splitting/near/597451615). And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything. r? @nikic cc @RalfJung MCP tracking issue rust-lang#153250

@rustbot

…-warn, r=GuillaumeGomez,traviscross Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` Added documentation for built-in `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` attributes using the #[doc(attribute = "...")] mechanism. Part of rust-lang#157604 @rustbot r? @GuillaumeGomez cc @fmease cc @mejrs

@lcnr

Fixup the refactoring errors in rust-lang#156246 r? @lcnr

@semarie

… r=jhpratt std: truncate thread names on NetBSD NetBSD [enforces limits on the length of thread names](https://man.netbsd.org/pthread_setname_np.3#DESCRIPTION). On all similar platforms (e.g. Linux, macOS) we truncate the Rust name so that at least some of the name is visible in the OS. CC @semarie

…-obligations, r=Kivooeo Guard clone suggestion against empty obligation errors Fixes rust-lang#148631

JonathanBrouwer · 2026-06-26T09:28:50Z

@bors r+ rollup=never p=5

rust-bors · 2026-06-26T09:28:54Z

📌 Commit c52b60f has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 6 pull requests Successful merges: - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158399 (std: truncate thread names on NetBSD) - #158430 (Guard clone suggestion against empty obligation errors)

rust-bors · 2026-06-26T09:46:24Z

💔 Test for c6ced33 failed: CI. Failed job:

auto - x86_64-gnu-llvm-22-2 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-26T09:54:56Z

@bors retry

…uwer Rollup of 6 pull requests Successful merges: - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158399 (std: truncate thread names on NetBSD) - #158430 (Guard clone suggestion against empty obligation errors)

rust-bors · 2026-06-26T10:01:40Z

💔 Test for 8ea116d failed: CI. Failed job:

auto - x86_64-msvc-ext1 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-26T10:17:57Z

@bors retry

rust-log-analyzer · 2026-06-26T10:24:17Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: dist-i686-linux
##[endgroup]
    Updating crates.io index
error: failed to get `adler2` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `adler2`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of ad/le/adler2 failed

Caused by:
  curl failed

Caused by:

…uwer Rollup of 6 pull requests Successful merges: - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158399 (std: truncate thread names on NetBSD) - #158430 (Guard clone suggestion against empty obligation errors)

rust-log-analyzer · 2026-06-26T10:51:32Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: dist-aarch64-freebsd
##[endgroup]
    Updating crates.io index
error: failed to get `adler2` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `adler2`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of ad/le/adler2 failed

Caused by:
  curl failed

Caused by:

rust-bors · 2026-06-26T10:54:15Z

💔 Test for 77d4a45 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-26T11:08:22Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  TOOLSTATE_REPO_ACCESS_TOKEN: 
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

JonathanBrouwer · 2026-06-26T11:21:59Z

@bors retry

rust-log-analyzer · 2026-06-26T11:24:20Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  TOOLSTATE_PUBLISH: 1
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

rust-bors · 2026-06-26T11:47:26Z

This pull request was unapproved due to being closed.

rust-log-analyzer · 2026-06-26T12:25:12Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  NO_DOWNLOAD_CI_LLVM: 1
  WIX: /d/a/rust/rust/wix
##[endgroup]
    Updating crates.io index
error: failed to get `cookie` as a dependency of package `cookie_store v0.21.1`
    ... which satisfies dependency `cookie_store = "^0.21.1"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (D:\a\rust\rust\src\ci\citool)`

Caused by:
  failed to load source for dependency `cookie`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of co/ok/cookie failed

Caused by:
  curl failed

Caused by:

rust-log-analyzer · 2026-06-26T13:55:46Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-distcheck
##[endgroup]
    Updating crates.io index
error: failed to get `adler2` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `adler2`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of ad/le/adler2 failed

Caused by:
  curl failed

Caused by:

oli-obk and others added 18 commits June 24, 2026 09:08

Move some methods that only need the region context onto that

b429456

Consistently taint root cx

7ebb859

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

Remove some unnecessary mutabilities

f44093d

Typeck children always have the same param env as their parent

7102a6c

Don't compute opaque types for typeck children. They are always the s…

7cb94f0

…ame as their parent

Add a convenience helper for doing type ops

7ccc34f

std: truncate thread names on NetBSD

ba2c9ba

cg_LLVM: Stop needing an alloca for volatile loads

9b188dd

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

add regression test for clone suggestion empty obligations

6d6fcc9

guard clone suggestion against empty obligation errors

f08762c

fixup the refactoring errors in 156246

c200d2f

Rollup merge of rust-lang#158355 - jdonszelmann:fixuop, r=lcnr

8b65dab

Fixup the refactoring errors in rust-lang#156246 r? @lcnr

Rollup merge of rust-lang#158430 - TaKO8Ki:fix-clone-suggestion-empty…

c52b60f

…-obligations, r=Kivooeo Guard clone suggestion against empty obligation errors Fixes rust-lang#148631

rust-bors Bot added the rollup A PR which is a rollup label Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

JonathanBrouwer closed this Jun 26, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jun 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

JonathanBrouwer commented Jun 26, 2026 •

edited by rustbot

Loading