Rollup of 7 pull requests by JonathanBrouwer · Pull Request #158442 · rust-lang/rust

JonathanBrouwer · 2026-06-26T11:47:02Z

Successful merges:

Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children)
cg_LLVM: Stop needing an alloca for volatile loads #157127 (cg_LLVM: Stop needing an alloca for volatile loads)
Attribute docs deprecated , warn, allow, cfg, deny, and forbid #158244 (Attribute docs deprecated , warn, allow, cfg, deny, and forbid )
Fixup the refactoring errors in #156246 #158355 (Fixup the refactoring errors in Introduce a RerunNonErased error type mirroring NoSolution, to better track when we're bailing #156246)
Move check_ffi_pure into the attribute parser #158361 (Move check_ffi_pure into the attribute parser)
std: truncate thread names on NetBSD #158399 (std: truncate thread names on NetBSD)
Guard clone suggestion against empty obligation errors #158430 (Guard clone suggestion against empty obligation errors)

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

…ame as their parent

convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`.

…rbid` * Added documentation for allow, cfg, deny, forbid, deprecated and warn attribute Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix typo Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback and add link to rustc book Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

@ghost

Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children Various things I noticed while figuring out how to best allow changing some borrowck errors into FCWs cc @rust-lang/types for the typeck children stuff, in case I missed some memo and am undoing some work r? @ghost need perf first

@nikic

…ve, r=nikic cg_LLVM: Stop needing an alloca for volatile loads This ended up also being reimplementing it to not use `load` of the `llvm_type`, since without doing that everything blew up horribly. cc the zulip conversation [#t-opsem > Defining volatile splitting @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/136281-t-opsem/topic/Defining.20volatile.20splitting/near/597451615). And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything. r? @nikic cc @RalfJung MCP tracking issue rust-lang#153250

@rustbot

…-warn, r=GuillaumeGomez,traviscross Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` Added documentation for built-in `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` attributes using the #[doc(attribute = "...")] mechanism. Part of rust-lang#157604 @rustbot r? @GuillaumeGomez cc @fmease cc @mejrs

@lcnr

Fixup the refactoring errors in rust-lang#156246 r? @lcnr

@JonathanBrouwer

…hanBrouwer Move `check_ffi_pure` into the attribute parser Updates rust-lang#153101 convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`. r? @JonathanBrouwer

@semarie

… r=jhpratt std: truncate thread names on NetBSD NetBSD [enforces limits on the length of thread names](https://man.netbsd.org/pthread_setname_np.3#DESCRIPTION). On all similar platforms (e.g. Linux, macOS) we truncate the Rust name so that at least some of the name is visible in the OS. CC @semarie

…-obligations, r=Kivooeo Guard clone suggestion against empty obligation errors Fixes rust-lang#148631

JonathanBrouwer · 2026-06-26T11:47:10Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-06-26T11:47:13Z

📌 Commit 4b9e13c has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

…uwer Rollup of 7 pull requests Successful merges: - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158361 (Move `check_ffi_pure` into the attribute parser) - #158399 (std: truncate thread names on NetBSD) - #158430 (Guard clone suggestion against empty obligation errors)

rust-bors · 2026-06-26T14:30:55Z

💔 Test for 3e3ec5c failed: CI. Failed job:

auto - aarch64-msvc-2 (web logs, enhanced plaintext logs)

rust-bors · 2026-06-26T14:31:28Z

This pull request was unapproved due to being closed.

rust-bors · 2026-06-26T14:51:07Z

☀️ Try build successful (CI)
Build commit: 2e2b7d9 (2e2b7d9d041a1dcfb46781fc1821ec2e4b8ba4d8)
Base parent: 40557f6 (40557f6225e337d68c8d4f086557ce54135f5dd9)

rust-log-analyzer · 2026-06-26T15:39:58Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  WIX: /c/a/rust/rust/wix
##[endgroup]
    Updating crates.io index
error: failed to get `adler2` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (C:\a\rust\rust\src\ci\citool)`

Caused by:
  failed to load source for dependency `adler2`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of ad/le/adler2 failed

Caused by:
  curl failed

Caused by:

oli-obk and others added 21 commits June 24, 2026 09:08

Move some methods that only need the region context onto that

b429456

Consistently taint root cx

7ebb859

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

Remove some unnecessary mutabilities

f44093d

Typeck children always have the same param env as their parent

7102a6c

Don't compute opaque types for typeck children. They are always the s…

7cb94f0

…ame as their parent

Add a convenience helper for doing type ops

7ccc34f

Move check_ffi_pure into the attribute parser

b2a46c9

convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`.

Use NoArgsAttributeParser for parsing #[ffi_pure]

c19c462

std: truncate thread names on NetBSD

ba2c9ba

cg_LLVM: Stop needing an alloca for volatile loads

9b188dd

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

add regression test for clone suggestion empty obligations

6d6fcc9

guard clone suggestion against empty obligation errors

f08762c

fixup the refactoring errors in 156246

c200d2f

Rollup merge of rust-lang#158355 - jdonszelmann:fixuop, r=lcnr

13cc1d2

Fixup the refactoring errors in rust-lang#156246 r? @lcnr

Rollup merge of rust-lang#158430 - TaKO8Ki:fix-clone-suggestion-empty…

4b9e13c

…-obligations, r=Kivooeo Guard clone suggestion against empty obligation errors Fixes rust-lang#148631

rust-bors Bot added the rollup A PR which is a rollup label Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

JonathanBrouwer closed this Jun 26, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 26, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 7 pull requests#158442

Rollup of 7 pull requests#158442
JonathanBrouwer wants to merge 21 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-kzF4Jb4

JonathanBrouwer commented Jun 26, 2026 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jun 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

JonathanBrouwer commented Jun 26, 2026 •

edited by rustbot

Loading