Rollup of 11 pull requests by JonathanBrouwer · Pull Request #158450 · rust-lang/rust

JonathanBrouwer · 2026-06-26T14:31:48Z

Successful merges:

Add arg splat experiment initial tuple impl #153697 (Add arg splat experiment initial tuple impl)
Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children)
cg_LLVM: Stop needing an alloca for volatile loads #157127 (cg_LLVM: Stop needing an alloca for volatile loads)
Suggest >= for => typo in closure and call argument positions #158376 (Suggest >= for => typo in closure and call argument positions)
Attribute docs deprecated , warn, allow, cfg, deny, and forbid #158244 (Attribute docs deprecated , warn, allow, cfg, deny, and forbid )
Fixup the refactoring errors in #156246 #158355 (Fixup the refactoring errors in Introduce a RerunNonErased error type mirroring NoSolution, to better track when we're bailing #156246)
Move check_ffi_pure into the attribute parser #158361 (Move check_ffi_pure into the attribute parser)
std: truncate thread names on NetBSD #158399 (std: truncate thread names on NetBSD)
Eliminate double length check in Vec::into_array #158418 (Eliminate double length check in Vec::into_array)
Guard clone suggestion against empty obligation errors #158430 (Guard clone suggestion against empty obligation errors)
Cleanup NumBuffer comment and replace ilog(10) with ilog10() #158448 (Cleanup NumBuffer comment and replace ilog(10) with ilog10())

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

…ame as their parent

convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`.

The parser suggests replacing `=>` with `>=` when it looks like a typo in a comparison, but it skipped the suggestion whenever a comma was an expected token. That excluded closure bodies used as call arguments, such as `iter.position(|x| x => &y)`, which is the case in rust-lang#149805. The comma exclusion was there to avoid suggesting `>=` for a missing comma between match arms, where `=>` is a real arm arrow. Those cases have a close brace in the expected token set, while the comparison cases do not, so gate on the close brace instead of the comma. Fixes rust-lang#149805

…rbid` * Added documentation for allow, cfg, deny, forbid, deprecated and warn attribute Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address review feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * add the right deprecated link Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix typo Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * fix phrasing Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback and add link to rustc book Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com> * address feedback Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

And remove redundant const fn

- const, async, and unsafe functions - const generics, complex types, and where clauses (including impl Tuple)

…uwer Rollup of 11 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158376 (Suggest `>=` for `=>` typo in closure and call argument positions) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158361 (Move `check_ffi_pure` into the attribute parser) - #158399 (std: truncate thread names on NetBSD) - #158418 (Eliminate double length check in `Vec::into_array`) - #158430 (Guard clone suggestion against empty obligation errors) - #158448 (Cleanup `NumBuffer` comment and replace `ilog(10)` with `ilog10()`)

rust-bors · 2026-06-26T15:41:30Z

💔 Test for bce7d98 failed: CI. Failed job:

auto - aarch64-gnu (web logs, enhanced plaintext logs)

jhpratt · 2026-06-26T16:19:50Z

@bors retry

…uwer Rollup of 11 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158376 (Suggest `>=` for `=>` typo in closure and call argument positions) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158361 (Move `check_ffi_pure` into the attribute parser) - #158399 (std: truncate thread names on NetBSD) - #158418 (Eliminate double length check in `Vec::into_array`) - #158430 (Guard clone suggestion against empty obligation errors) - #158448 (Cleanup `NumBuffer` comment and replace `ilog(10)` with `ilog10()`)

rust-bors · 2026-06-26T16:33:20Z

💔 Test for 511f2e2 failed: CI. Failed job:

auto - aarch64-msvc-1 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-26T16:35:47Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  DEPLOY: 1
  IMAGE: dist-powerpc64-linux-musl
##[endgroup]
    Updating crates.io index
error: failed to get `askama_derive` as a dependency of package `askama_macros v0.16.0`
    ... which satisfies dependency `askama_macros = "=0.16.0"` of package `askama v0.16.0`
    ... which satisfies dependency `askama = "^0.16.0"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `askama_derive`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of as/ka/askama_derive failed

Caused by:
  curl failed

Caused by:

JonathanBrouwer · 2026-06-26T16:44:30Z

@bors retry

rust-log-analyzer · 2026-06-26T17:07:48Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  RUST_BACKTRACE: 1
  TOOLSTATE_PUBLISH: 1
##[endgroup]
    Updating crates.io index
error: failed to get `cookie` as a dependency of package `cookie_store v0.21.1`
    ... which satisfies dependency `cookie_store = "^0.21.1"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `cookie`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of co/ok/cookie failed

Caused by:
  curl failed

Caused by:

…uwer Rollup of 11 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #158360 (Various borrowck cleanups and param_env/opaque_types_defined_by query simplifications for typeck children) - #157127 (cg_LLVM: Stop needing an alloca for volatile loads) - #158376 (Suggest `>=` for `=>` typo in closure and call argument positions) - #158244 (Attribute docs `deprecated` , `warn`, `allow`, `cfg`, `deny`, and `forbid` ) - #158355 (Fixup the refactoring errors in #156246) - #158361 (Move `check_ffi_pure` into the attribute parser) - #158399 (std: truncate thread names on NetBSD) - #158418 (Eliminate double length check in `Vec::into_array`) - #158430 (Guard clone suggestion against empty obligation errors) - #158448 (Cleanup `NumBuffer` comment and replace `ilog(10)` with `ilog10()`)

rust-bors · 2026-06-26T18:13:21Z

💔 Test for 5ce1e68 failed: CI. Failed job:

auto - dist-i586-gnu-i586-i686-musl (web logs, enhanced plaintext logs)

rust-bors · 2026-06-26T18:22:50Z

This pull request was unapproved due to being closed.

rust-log-analyzer · 2026-06-26T18:34:50Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: aarch64-gnu-debug
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

rust-log-analyzer · 2026-06-26T19:04:57Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: aarch64-gnu
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

rust-log-analyzer · 2026-06-26T19:38:54Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  NO_DOWNLOAD_CI_LLVM: 1
  WIX: /c/a/rust/rust/wix
##[endgroup]
    Updating crates.io index
error: failed to get `cc` as a dependency of package `ring v0.17.11`
    ... which satisfies dependency `ring = "^0.17"` of package `rustls v0.23.23`
    ... which satisfies dependency `rustls = "^0.23.22"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (C:\a\rust\rust\src\ci\citool)`

Caused by:
  failed to load source for dependency `cc`

Caused by:

rust-log-analyzer · 2026-06-26T20:50:33Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: dist-i586-gnu-i586-i686-musl
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

oli-obk and others added 30 commits June 24, 2026 09:08

Move some methods that only need the region context onto that

b429456

Consistently taint root cx

7ebb859

Instead of having to taint both infcx and root_cx, we always just taint infcx (which usually gets automatically tainted from emitting diagnostics), and at the end (before dropping the infcx) we move the taint over to the root_cx

Remove some unnecessary mutabilities

f44093d

Typeck children always have the same param env as their parent

7102a6c

Don't compute opaque types for typeck children. They are always the s…

7cb94f0

…ame as their parent

Add a convenience helper for doing type ops

7ccc34f

Move check_ffi_pure into the attribute parser

b2a46c9

convert `FfiPureParser` to a full `AttributeParser` so its `finalize` can check for a sibling `#[ffi_const]` and reject `#[ffi_pure]` during attribute parsing, replacing `check_ffi_pure` in `rustc_passes`.

Use NoArgsAttributeParser for parsing #[ffi_pure]

c19c462

std: truncate thread names on NetBSD

ba2c9ba

Eliminate double length check in Vec::into_array

5ba35ba

cg_LLVM: Stop needing an alloca for volatile loads

9b188dd

And while I'm here, improve the tests to check that the unaligned ones are actually unaligned, since `unaligned_volatile_load::<u8>` doesn't actually test anything.

add regression test for clone suggestion empty obligations

6d6fcc9

guard clone suggestion against empty obligation errors

f08762c

fixup the refactoring errors in 156246

c200d2f

Limit splat AST and FnDecl to 255 args

6c52a70

And remove redundant const fn

Impl HIR FnSig for #[splat]

5d0c6ba

Impl HIR typeck for #[splat]

e0a35a0

Remove a leftover direct call to fn_ctxt.label_generic_mismatches

472c197

Fix ICE in label_fn_like when splatted arg index is out of bounds

50c5d85

Impl MIR lowering side-tables for #[splat]

9e48cd9

Impl actual MIR lowering for #[splat]

2bb9dab

Impl TypeInfo for splat

50c658c

Add UI tests for #[splat] unhappy path, generics, fn colors

dc3889a

- const, async, and unsafe functions - const generics, complex types, and where clauses (including impl Tuple)

Add failing test for #[splat] with dyn AsRef<T> where T: Tuple

633b89b

Add splat UI tests for 255 splatted arg limit

3173c8b

UI test arg diffs greater than u8::MAX

18185d0

Fix output normtn in splat-fn-ptr-tuple.rs

4d9ae09

Remove FIXME comment that is not needed anymore

8b90f5c

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2026

JonathanBrouwer closed this Jun 26, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 26, 2026

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jun 26, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

jhpratt commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

JonathanBrouwer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-bors Bot commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

rust-log-analyzer commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

JonathanBrouwer commented Jun 26, 2026 •

edited by rustbot

Loading