MC/DC Coverage re-introduction (1/3): THIR data gathering - #161222
MC/DC Coverage re-introduction (1/3): THIR data gathering#161222RenjiSann wants to merge 4 commits into
Conversation
|
Some changes occurred in match lowering cc @Nadrieril Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred in coverage instrumentation. cc @Zalathar |
This comment has been minimized.
This comment has been minimized.
7e45625 to
d04f977
Compare
This comment has been minimized.
This comment has been minimized.
d04f977 to
bc4d8b1
Compare
|
I'm quite confused that you've asked David to review this, who's not a maintainer of the coverage implementation, rather than Zalathar, who is. |
|
@jyn514 probably because David is the compiler champion for this goal https://rust-lang.github.io/goals/2026/mcdc-coverage-support.html |
|
This PR series (?) seems to rely heavily on re-adding chunks of the old implementation that was specifically removed for imposing a heavy maintenance burden. I would not want that point to go unremarked. The approach of doing any kind of non-trivial analysis during MIR building also seems like a dead end. It's already not working well for branch coverage, and MC/DC necessarily imposes a much higher complexity burden than branch coverage does. |
|
☔ The latest upstream changes (presumably #162009) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
Tracking issue: rust-lang/goals#638
Identify MC/DC decision in the AST form, to allow for incoming instrumentation and mappings creation.
-Z coverage-options=mcdcflagr? @davidtwco