Treat identity region outlives as true - #161963
Open
adwinwhite wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
Just found out this is a tracked issue - rust-lang/project-assumptions-on-binders#19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161733
We rewrite region outlives to
Orby combining upper bounds of one region and lower bounds of the other. However, regions in identity region outlives may have no relation to other regions. So it was considered as false.An alternative is to eagerly handle identity region outlives at the construction sites. That's a lot and covering all current and future creation is difficult.
The real purpose of this PR is to play with the new DSL :3
r? @khyperia