Rerun tests/debuginfo tests if repr data has changed - #161967
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
jieyouxu
reviewed
Aug 29, 2026
| related.push(path); | ||
| } | ||
|
|
||
| // `minicore.rs` test auxiliary: we need to make sure tests get rerun if this changes. | ||
| related.push(config.src_root.join("tests").join("auxiliary").join("minicore.rs")); | ||
|
|
||
| // `tests/debuginfo` blessed files | ||
| match variant.debugger { | ||
| Some(debugger @ Debugger::Lldb | debugger @ Debugger::Gdb) => { |
Member
There was a problem hiding this comment.
Could we exhaustively match Debugger kinds here?
Walnut356
force-pushed
the
stamp_repr_data
branch
from
August 30, 2026 07:33
a4a0468 to
63adf37
Compare
jieyouxu
approved these changes
Aug 30, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 30, 2026
Rerun `tests/debuginfo` tests if repr data has changed Resolves rust-lang#161138 This also includes the necessary checking for GDB's data even though none exists atm (rust-lang#160377 will contain the first set). The extra handling doesn't hurt anything since we have to account for all the other tests that don't have repr data anyway. In a followup, I can rename the `lldb_input` directory to something else (see: rust-lang#160137 (comment)). Doing so requires me to touch a bunch of other places where the name is used, so it should probably be it's own PR. Making sure the tests rerun when the data changes is higher priority though atm. r? @jieyouxu , @Kobzol cc @Mark-Simulacrum
This was referenced Aug 30, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 30, 2026
Rollup merge of #161967 - Walnut356:stamp_repr_data, r=jieyouxu Rerun `tests/debuginfo` tests if repr data has changed Resolves #161138 This also includes the necessary checking for GDB's data even though none exists atm (#160377 will contain the first set). The extra handling doesn't hurt anything since we have to account for all the other tests that don't have repr data anyway. In a followup, I can rename the `lldb_input` directory to something else (see: #160137 (comment)). Doing so requires me to touch a bunch of other places where the name is used, so it should probably be it's own PR. Making sure the tests rerun when the data changes is higher priority though atm. r? @jieyouxu , @Kobzol cc @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #161138
This also includes the necessary checking for GDB's data even though none exists atm (#160377 will contain the first set). The extra handling doesn't hurt anything since we have to account for all the other tests that don't have repr data anyway.
In a followup, I can rename the
lldb_inputdirectory to something else (see: #160137 (comment)). Doing so requires me to touch a bunch of other places where the name is used, so it should probably be it's own PR. Making sure the tests rerun when the data changes is higher priority though atm.r? @jieyouxu , @Kobzol
cc @Mark-Simulacrum