Remove -Zsaturating-float-casts flag - #161971
Conversation
|
cc @rust-lang/miri
cc @bjorn3 |
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
00a15d4 to
450162e
Compare
I added this flag back in 2017 to enable benchmarking of the saturating semantics when it was newly implemented and still experimental. But saturation has been the official semantics for float<->int `as` casts for years now. A flag for turning it off no longer serves any purpose, it's just `-Zplease-miscompile-casts` now.
450162e to
c7d949d
Compare
|
Moved the miri part to rust-lang/miri#5297 The changes to codegen backends can only be separated out by first removing the uses of the flag there, waiting for the next sync, and then removing the rustc flag. That seems unnecessary but will do if the codegen backend maintainers would prefer. |
|
@rustbot reroll |
|
FWIW it'd have been fine to do the Miri part here. For tiny changes that logically belong to a rustc PR we're not strict. But a separate PR also works. :) |
|
Cc @rust-lang/compiler in case someone is attached to this flag. r=me if nobody speaks up within the next few days. Thanks for the cleanup! |
I added this flag back in 2017 (#45205) to enable benchmarking of the saturating semantics when it was newly implemented and still experimental. But saturation has been the official semantics for float<->int
ascasts for years now. A flag for turning it off no longer serves any purpose, it's just-Zplease-miscompile-castsnow.