Improve tests for #[track_caller] in async - #161972
Open
theemathas wants to merge 6 commits into
Open
Conversation
Previously, these tests were testing the wrong feature gate, and had unnecessary type errors.
This is done so that we can test whether the location used is at the function call site or the await site.
Collaborator
|
cc @rust-lang/miri |
Collaborator
|
rustbot has assigned @ShoyuVanilla. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Excluded the gcc backend from a test as per @antoyo's advice |
RalfJung
reviewed
Aug 29, 2026
|
|
||
| //@ edition:2021 | ||
| //@ revisions: afn cls afn_cls nofeat | ||
| // |
Member
There was a problem hiding this comment.
Suggested change
| // | |
| //@ run-native |
to ensure the line numbers are indeed correct according to regular rustc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue for
async_fn_track_caller: #110011Tracking issue for
closure_track_caller: #87417I recommend reviewing each commit individually.
cc @RalfJung, who requested the test to be added to Miri.
For your convenience, below is the output of
diff tests/ui/async-await/track-caller/panic-track-caller.rs src/tools/miri/tests/pass/async-panic-track-caller.rs: