Rollup of 3 pull requests - #161997
Open
jhpratt wants to merge 6 commits into
Open
Conversation
Filters out false positives for the 'imperfect derives' E0277 note by checking if ADT fields satisfy the trait independently of the failing generic parameter.
…17, r=mejrs Add accurate targeting for imperfect derives diagnostic in `E0277` Resolves rust-lang#157117 Follow-up rust-lang#158764 This PR implements accurate targeting for the E0277 "imperfect derives" suggestion so it only triggers when all fields of the ADT satisfy the trait independently of the failing generic parameter. False positives (like `struct S<T>(T)`) are now successfully filtered out, while true cases (like `PhantomData<T>`) still correctly emit the help note. r? @estebank cc @mejrs @khyperia
…nilla Add regression test for TAIT in extern fn ICE with the new solver Fixes rust-lang#156345
…=ShoyuVanilla add regression test for ICE unexpected region regression test for rust-lang#143896
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 9bbaf3f failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
E0277#159363 (Add accurate targeting for imperfect derives diagnostic inE0277)r? @ghost
Create a similar rollup