Clean up and streamline snapshot data structures#55906
Merged
bors merged 8 commits intorust-lang:masterfrom Nov 25, 2018
Merged
Clean up and streamline snapshot data structures#55906bors merged 8 commits intorust-lang:masterfrom
bors merged 8 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits clean up the snapshot structures a bit, so they are more consistent with each other and with the
enacrate.They also remove the
OpenSnapshotandCommittedSnapshotentries in the undo log, just like I did for theenacrate in rust-lang/ena#14. This PR in combination with thatenaPR reduces instruction counts by up to 6% on benchmarks.r? @nikomatsakis. Note that this isn't quite ready for landing, because the
enadependency in the first commit needs to be updated once rust-lang/ena#14 lands. But otherwise it should be good.