Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was necessary before, because
declare_raw_fnwould always applythe default optimization attributes to every declared function.
Then
attributes::from_fn_attrswould have to remove the defaultattributes in the case of, e.g.
#[optimize(speed)]in a-Osbuild.(see
src/test/codegen/optimize-attr-1.rs)However, every relevant callsite of
declare_raw_fn(i.e. where weactually generate code for the function, and not e.g. a call to an
intrinsic, where optimization attributes don't [?] matter)
calls
from_fn_attrs, so we can remove the attribute settingfrom
declare_raw_fn, and rely onfrom_fn_attrsto apply the correctattributes all at once.
r? @ghost (blocked on #94221)
@rustbot label S-blocked