Implement remaining aarch64 SHA-3 LLVM intrinsics#1666
Merged
Conversation
bjorn3
reviewed
Jul 2, 2026
Comment on lines
+1022
to
+1023
| let band_not = fx.bcx.ins().band_not(b_lane, c_lane); | ||
| fx.bcx.ins().bxor(a_lane, band_not) |
Member
There was a problem hiding this comment.
Isn't this supposed to be b ^ (a & !c) rather than a ^ (b & !c)?
Contributor
Author
There was a problem hiding this comment.
I think the current order is right. Testing against stdarch, b ^ (a & !c) results in 8 failing vbcaxq tests, while the current approach passes all.
Member
There was a problem hiding this comment.
Ah, the instruction is bcax d, n, m, a, but the operation in the docs lists the operands as m, n, a, which indeed results in a ^ (b & !c) as correct order.
bjorn3
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the remaining SHA-3 intrinsics.
Needed for ML-KEM / ML-DSA support.
graviolahas a feature flag which makes use oflibcruxfor PQC. Those tests aren't currently run, but can be enabled in the future (once a few more missing intrinsics are added).graviolaswitched to a native ML-KEM implementation.