fix: remove trailing spaces when rewriting same line missing comments#6575
Open
ytmimi wants to merge 1 commit intorust-lang:mainfrom
Open
fix: remove trailing spaces when rewriting same line missing comments#6575ytmimi wants to merge 1 commit intorust-lang:mainfrom
ytmimi wants to merge 1 commit intorust-lang:mainfrom
Conversation
Fixes 6568 When using `style_edition=2024` trailing whitespace was not properly removed when foramtting same line comments.
Member
|
i think we may need to gate this behind 27, as annoying as that would be. thoughts? |
Contributor
Author
|
The thought crossed my mind. though I think the caveats in our stability guarantee cover us here. I think either the note about comments or bugs would apply. To quote what we have in the README (emphasis mine):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6568
When using
style_edition=2024trailing whitespace was not properly removed when foramtting same line comments.