[import_granularity] Allow formatting of use behind #[cfg*]#6808
Open
dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
Open
[import_granularity] Allow formatting of use behind #[cfg*]#6808dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
import_granularity] Allow formatting of use behind #[cfg*]#6808dingxiangfei2009 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
Fix rust-lang#6666 We would like to allow formatting items with attributes that conceptually allows outer styling as well. Signed-off-by: Xiangfei Ding <dingxiangfei2009@protonmail.ch>
dingxiangfei2009
force-pushed
the
issue-6666
branch
from
9fd2c27 to
1bc57ce
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Author
|
cc @jieyouxu I had to migrate it to a new PR because the source branch was cc @matthewhughes934 I had addressed your review comments in #6723 including some additional tests. |
Author
|
@rustbot label +UO-imports_granularity |
jieyouxu
added
the
F-impacts-unstable-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6666
Related to #4991
Replace #6723
We would like to allow formatting items with attributes that conceptually allows outer styling as well. This is now tested against other granularity settings under the
import_granularityflag.Migrating from #6723 because PR was initiated from a wrong branch.