Repository navigation
Struct fields: avoid stripping comments in parentheses - #7168
Draft
matthewhughes934 wants to merge 1 commit into
Draft
matthewhughes934 wants to merge 1 commit into
matthewhughes934 wants to merge 1 commit into
Conversation
This goes part way to address[1]. The comments are only preserved When
there's a type in the field, this doesn't address empty parenthesis
being strip of comments, e.g. the following formatting still occurs:
field: (/* some comment*/) -> field: ()
I was looking for a generic 'add this comment alongside this other
content' function but couldn't find one, so I've tried to add one that
I'm hoping can be of general use.
References: rust-lang#6642 [1]
rustbot
added
the
S-waiting-on-author
1 of 2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes part way to address[1]. The comments are only preserved When there's a type in the field, this doesn't address empty parenthesis being strip of comments, e.g. the following formatting still occurs:
I was looking for a generic 'add this comment alongside this other content' function but couldn't find one, so I've tried to add one that I'm hoping can be of general use.
References: #6642 [1]