Repository navigation
Enforce comment width in item lists - #7174
Draft
matthewhughes934 wants to merge 1 commit into
Draft
matthewhughes934 wants to merge 1 commit into
matthewhughes934 wants to merge 1 commit into
Conversation
I noticed while investigating an issue[1] that these comments were being rewritten to `max_width`. If you view more context in the modified test files, particularly `tests/target/comments-in-lists/wrap-comments-not-normalized.rs`, you'll see the changes are consistent with how existing comments in that test were formatted (albeit still inconsistent with some other comments, I'll handle these separately). References: rust-lang#7167 [1]
rustbot
added
the
S-waiting-on-author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while investigating an issue[1] that these comments were being rewritten to
max_width.If you view more context in the modified test files, particularly
tests/target/comments-in-lists/wrap-comments-not-normalized.rs, you'll see the changes are consistent with how existing comments in that test were formatted (albeit still inconsistent with some other comments, I'll handle these separately).References: #7167 [1]