Skip to content

Comments

test interleaving load/store roundtrip#2029

Merged
folkertdev merged 2 commits intorust-lang:mainfrom
folkertdev:interleaving-load-store-roundtrip
Feb 18, 2026
Merged

test interleaving load/store roundtrip#2029
folkertdev merged 2 commits intorust-lang:mainfrom
folkertdev:interleaving-load-store-roundtrip

Conversation

@folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Feb 17, 2026

Well, turns out some of these were extremely broken on aarch64_be

@folkertdev folkertdev force-pushed the interleaving-load-store-roundtrip branch 4 times, most recently from 2a1f0fb to 590801b Compare February 17, 2026 18:24
@folkertdev folkertdev force-pushed the interleaving-load-store-roundtrip branch from 590801b to 965ef66 Compare February 17, 2026 18:46
@folkertdev
Copy link
Contributor Author

cc @adamgemmell but really all this does is add more tests. The failures i encountered while making the changes indicate that this is all actually fairly well-tested.

@folkertdev folkertdev marked this pull request as ready for review February 17, 2026 18:58
@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2026

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, sayantn

@folkertdev
Copy link
Contributor Author

actually

r? sayantn

because we should probably merge this before #2025

@rustbot rustbot assigned sayantn and unassigned Amanieu Feb 17, 2026
@sayantn
Copy link
Contributor

sayantn commented Feb 17, 2026

@folkertdev lgtm, but I am not too familiar with the semantics of ARMBE loads. This PR changes a lot of intrinsic implementations for ARMBE, and it would be nice if we could confirm that this is the correct behavior

@folkertdev
Copy link
Contributor Author

Yeah, fair. I'm not too worried here because of the intrinsic tests that do end up exercising the functions that changed, but let's see.

@folkertdev
Copy link
Contributor Author

Oh also note that I'm only actually touching the unsigned variants of these functions. They used to defer to the signed variants, but applied additional shuffling. Logically, that just does not make sense.

@sayantn
Copy link
Contributor

sayantn commented Feb 17, 2026

That's a nice point, at least we are making it more consistent. I don't have a problem with merging this rn, as this will unblock some other PRs.

@folkertdev folkertdev added this pull request to the merge queue Feb 18, 2026
Merged via the queue into rust-lang:main with commit a8bb803 Feb 18, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants