test interleaving load/store roundtrip#2029
Conversation
2a1f0fb to
590801b
Compare
590801b to
965ef66
Compare
|
cc @adamgemmell but really all this does is add more tests. The failures i encountered while making the changes indicate that this is all actually fairly well-tested. |
|
r? @Amanieu rustbot has assigned @Amanieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
actually r? sayantn because we should probably merge this before #2025 |
|
@folkertdev lgtm, but I am not too familiar with the semantics of ARMBE loads. This PR changes a lot of intrinsic implementations for ARMBE, and it would be nice if we could confirm that this is the correct behavior |
|
Yeah, fair. I'm not too worried here because of the intrinsic tests that do end up exercising the functions that changed, but let's see. |
|
Oh also note that I'm only actually touching the unsigned variants of these functions. They used to defer to the signed variants, but applied additional shuffling. Logically, that just does not make sense. |
|
That's a nice point, at least we are making it more consistent. I don't have a problem with merging this rn, as this will unblock some other PRs. |
Well, turns out some of these were extremely broken on
aarch64_be