Skip to content

x86: Followup to add const for pack intrinsics and tests #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okaneco wants to merge 4 commits into
base: main
Choose a base branch
from
+169 −94
Open

x86: Followup to add const for pack intrinsics and tests #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c53ca2
x86: Followup to add const for pack intrinsics
okaneco Feb 20, 2026
3f65d51
Add const to `sse41` intrinsics
okaneco Feb 20, 2026
a188c12
Add const to `avx2` intrinsics
okaneco Feb 20, 2026
9fe604f
Add const to `avx512bw` intrinsics
okaneco Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions crates/core_arch/src/x86/avx2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,10 +2323,11 @@ pub const fn _mm256_or_si256(a: __m256i, b: __m256i) -> __m256i {
#[target_feature(enable = "avx2")]
#[cfg_attr(test, assert_instr(vpacksswb))]
#[stable(feature = "simd_x86", since = "1.27.0")]
pub fn _mm256_packs_epi16(a: __m256i, b: __m256i) -> __m256i {
#[rustc_const_unstable(feature = "stdarch_const_x86", issue = "149298")]
pub const fn _mm256_packs_epi16(a: __m256i, b: __m256i) -> __m256i {
unsafe {
let max = simd_splat(i16::from(i8::MAX));
let min = simd_splat(i16::from(i8::MIN));
let max = simd_splat(i8::MAX as i16);
let min = simd_splat(i8::MIN as i16);

let clamped_a = simd_imax(simd_imin(a.as_i16x16(), max), min)
.as_m256i()
Expand Down Expand Up @@ -2356,10 +2357,11 @@ pub fn _mm256_packs_epi16(a: __m256i, b: __m256i) -> __m256i {
#[target_feature(enable = "avx2")]
#[cfg_attr(test, assert_instr(vpackssdw))]
#[stable(feature = "simd_x86", since = "1.27.0")]
pub fn _mm256_packs_epi32(a: __m256i, b: __m256i) -> __m256i {
#[rustc_const_unstable(feature = "stdarch_const_x86", issue = "149298")]
pub const fn _mm256_packs_epi32(a: __m256i, b: __m256i) -> __m256i {
unsafe {
let max = simd_splat(i32::from(i16::MAX));
let min = simd_splat(i32::from(i16::MIN));
let max = simd_splat(i16::MAX as i32);
let min = simd_splat(i16::MIN as i32);

let clamped_a = simd_imax(simd_imin(a.as_i32x8(), max), min)
.as_m256i()
Expand Down Expand Up @@ -2389,10 +2391,11 @@ pub fn _mm256_packs_epi32(a: __m256i, b: __m256i) -> __m256i {
#[target_feature(enable = "avx2")]
#[cfg_attr(test, assert_instr(vpackuswb))]
#[stable(feature = "simd_x86", since = "1.27.0")]
pub fn _mm256_packus_epi16(a: __m256i, b: __m256i) -> __m256i {
#[rustc_const_unstable(feature = "stdarch_const_x86", issue = "149298")]
pub const fn _mm256_packus_epi16(a: __m256i, b: __m256i) -> __m256i {
unsafe {
let max = simd_splat(i16::from(u8::MAX));
let min = simd_splat(i16::from(u8::MIN));
let max = simd_splat(u8::MAX as i16);
let min = simd_splat(u8::MIN as i16);

let clamped_a = simd_imax(simd_imin(a.as_i16x16(), max), min)
.as_m256i()
Expand Down Expand Up @@ -2422,10 +2425,11 @@ pub fn _mm256_packus_epi16(a: __m256i, b: __m256i) -> __m256i {
#[target_feature(enable = "avx2")]
#[cfg_attr(test, assert_instr(vpackusdw))]
#[stable(feature = "simd_x86", since = "1.27.0")]
pub fn _mm256_packus_epi32(a: __m256i, b: __m256i) -> __m256i {
#[rustc_const_unstable(feature = "stdarch_const_x86", issue = "149298")]
pub const fn _mm256_packus_epi32(a: __m256i, b: __m256i) -> __m256i {
unsafe {
let max = simd_splat(i32::from(u16::MAX));
let min = simd_splat(i32::from(u16::MIN));
let max = simd_splat(u16::MAX as i32);
let min = simd_splat(u16::MIN as i32);

let clamped_a = simd_imax(simd_imin(a.as_i32x8(), max), min)
.as_m256i()
Expand Down Expand Up @@ -5064,7 +5068,7 @@ mod tests {
}

#[simd_test(enable = "avx2")]
fn test_mm256_packs_epi16() {
const fn test_mm256_packs_epi16() {
let a = _mm256_set1_epi16(2);
let b = _mm256_set1_epi16(4);
let r = _mm256_packs_epi16(a, b);
Expand All @@ -5080,7 +5084,7 @@ mod tests {
}

#[simd_test(enable = "avx2")]
fn test_mm256_packs_epi32() {
const fn test_mm256_packs_epi32() {
let a = _mm256_set1_epi32(2);
let b = _mm256_set1_epi32(4);
let r = _mm256_packs_epi32(a, b);
Expand All @@ -5090,7 +5094,7 @@ mod tests {
}

#[simd_test(enable = "avx2")]
fn test_mm256_packus_epi16() {
const fn test_mm256_packus_epi16() {
let a = _mm256_set1_epi16(2);
let b = _mm256_set1_epi16(4);
let r = _mm256_packus_epi16(a, b);
Expand All @@ -5106,7 +5110,7 @@ mod tests {
}

#[simd_test(enable = "avx2")]
fn test_mm256_packus_epi32() {
const fn test_mm256_packus_epi32() {
let a = _mm256_set1_epi32(2);
let b = _mm256_set1_epi32(4);
let r = _mm256_packus_epi32(a, b);
Expand Down
Loading