document differences from pure hardware behavior#2176
Open
RalfJung wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#153990 by documenting that the NaN rules also apply to stdarch intrinsics.
Rust does not have a general rule of "signaling NaN may be treated like quiet NaN"; that only affects a few operations (pow, powi, max, min) which just then state this caveat in their respective docs. My understanding is that stdarch wants to properly reflect hardware behavior here. That means however stdarch must be careful not to use the normal LLMV intrinsics for such operations. I think nvptx currently may be getting this wrong, which is already tracked at #2056.
@Amanieu also mentioned that for subnormals, the intent is that stdarch matches the hardware. I suspect this may be tricky since LLVM will probably reserve the right to perform constant propagation with full subnormal precision, i.e., "guaranteed subnormal flushing" is probably not going to work. But right now the ARM32 NEON intrinsics are unsound and can cause UB (rust-lang/rust#129880) so we can't really even have that discussion yet until that is fixed.