Skip to content

Comments

Enable [review-changes-since] feature for the rust-lang organization#2294

Merged
Urgau merged 1 commit intorust-lang:masterfrom
Urgau:org-wide-review-changes-since
Feb 23, 2026
Merged

Enable [review-changes-since] feature for the rust-lang organization#2294
Urgau merged 1 commit intorust-lang:masterfrom
Urgau:org-wide-review-changes-since

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Feb 19, 2026

Now that we support org-wide config (thks to #2292), I would like to enable the first feature for triagebot-enabled repositories in the rust-lang organization.

The "View changes since this review" link seems like a good first candidate, so that's what this PR enables.

cc @Mark-Simulacrum

@Urgau Urgau requested a review from Kobzol February 19, 2026 18:13
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to announce this somehow. Maybe in the infra announcements channel @jieyouxu ?

View changes since this review

@jieyouxu
Copy link
Member

Maybe in the infra announcements channel @jieyouxu ?

Yes, I think that would be a good idea.

@Urgau
Copy link
Member Author

Urgau commented Feb 20, 2026

Doing an announcement seems reasonable to me as well.

I took the liberty to write one (with AI help), what do you think?


Triagebot Organization-Wide Defaults

We’re introducing organization-wide configuration defaults for Triagebot!

This change will make it easier to roll out improvements across all triagebot-enabled rust-lang repositories without needing separate pull requests for each one. Individual repositories can still opt out of any feature by opening a pull request to the rust-lang/triagebot repository.

As the first feature under this new setup, "View changes since this review" links will be enabled across the organization soon. This feature makes it easier to see what’s changed in a pull request since your last review, helping reviewers stay up to date with less effort.

@Kobzol
Copy link
Member

Kobzol commented Feb 20, 2026

Would be nice to link the file which should be modified when talking about opening the PR, otherwise looks good.

@Urgau
Copy link
Member Author

Urgau commented Feb 20, 2026

Sure, added a link to file rust-lang.triagebot.toml file with highlighting on how to exclude a repo.

@Kobzol
Copy link
Member

Kobzol commented Feb 20, 2026

I think that only t-infra people can post into the announcements channel (?). I'll let jieyouxu take a look, then we can post it.

@jieyouxu
Copy link
Member

Looks good to me as well

1 similar comment
@jieyouxu

This comment was marked as duplicate.

@Urgau
Copy link
Member Author

Urgau commented Feb 23, 2026

The announcement was posted 2 days ago, #t-infra/announcements > Triagebot Organization-Wide Defaults @ 💬.

Let's go.

@Urgau Urgau added this pull request to the merge queue Feb 23, 2026
Merged via the queue into rust-lang:master with commit c9aaf1f Feb 23, 2026
3 checks passed
@Urgau Urgau deleted the org-wide-review-changes-since branch February 23, 2026 16:39
@Urgau
Copy link
Member Author

Urgau commented Feb 23, 2026

It worked! rust-lang/rust-forge#1013 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants