Compiler triage agenda: retrieve weekly perf logs#2299
Open
apiraino wants to merge 1 commit intorust-lang:masterfrom
Open
Compiler triage agenda: retrieve weekly perf logs#2299apiraino wants to merge 1 commit intorust-lang:masterfrom
apiraino wants to merge 1 commit intorust-lang:masterfrom
Conversation
Kobzol
reviewed
Feb 24, 2026
|
|
||
| pub async fn get_compiler_perf_triage_logs(date: NaiveDate) -> anyhow::Result<String> { | ||
| // Perf triage logs are usually merged a few days before building the T-compiler triage meeting | ||
| let try_days = [date.day() - 3, date.day() - 2, date.day() - 1, date.day()]; |
Member
There was a problem hiding this comment.
This approach won't really work when you have the agenda on the first of March, and the perf. logs were generated on the 29th of February 😆 Either it should be using proper datetime subtracting, or (and I think that would be better in general), I'd use [this](#t-compiler/performance > Automating pulling triage logs from r-l/rustc-perf @ 💬) endpoint to enumerate all files from the triage/year directory and take the newest one.
Contributor
Author
There was a problem hiding this comment.
you're right, I have should have thought about that. Ok, I will use the other API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automates a little piece of building the weekly compiler agenda for triage meetings. Will attempt to retrieve the weekly compiler perf logs looking around in the
rust-lang/rustc-perfgit repositoryr? @Kobzol
thanks!