Open
Conversation
cathay4t
approved these changes
Jan 10, 2024
Member
|
@vthib Can you review your patch? Looks like I cannot do that for you from my end. |
auto-merge was automatically disabled
January 10, 2024 17:55
Head branch was pushed to by a user without write access
Contributor
Author
|
@cathay4t I rebased, should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
First of all, thanks for this crate. I've started using it and there are a few changes that I would like to upstream. First one is a simple method to set the status, which mirrors the get status one.