-
-
Notifications
You must be signed in to change notification settings - Fork 485
Update getrandom, rand_core; rename OsRng → SysRng
#1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+143
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b99e67 to
158e49d
Compare
This was referenced Dec 23, 2025
tarcieri
reviewed
Dec 26, 2025
158e49d to
99ae06f
Compare
Member
Author
|
Updated: use |
newpavlov
approved these changes
Dec 27, 2025
tarcieri
approved these changes
Dec 27, 2025
tarcieri
reviewed
Dec 27, 2025
tarcieri
added a commit
to dalek-cryptography/curve25519-dalek
that referenced
this pull request
Dec 27, 2025
Most of the changes in this PR are actually from the associated `rand` crate updates which are happening in rust-random/rand#1697, notably `OsRng` has been renamed to `SysRng` (and is now provided by the `getrandom` crate). We do use some `rand_core` APIs in a few places though, like the STROBE implementation, where this migrates from `rand_core::le` to `rand_core::utils`.
tarcieri
added a commit
to dalek-cryptography/curve25519-dalek
that referenced
this pull request
Dec 27, 2025
Most of the changes in this PR are actually from the associated `rand` crate updates which are happening in rust-random/rand#1697, notably `OsRng` has been renamed to `SysRng` (and is now provided by the `getrandom` crate). We do use some `rand_core` APIs in a few places though, like the STROBE implementation, where this migrates from `rand_core::le` to `rand_core::utils`.
99ae06f to
d78703e
Compare
1 task
tarcieri
added a commit
to dalek-cryptography/curve25519-dalek
that referenced
this pull request
Dec 28, 2025
rust-random/rand#1697 which updates `rand_core` to v0.10.0-rc-3 for the `rand` crate has been merged. This removes `patch.crates-io` for `getrandom` and pins to the merged commit revision for `rand`, as well as bumping the `getrandom` dependency of `x25519-dalek` to v0.4.0-rc.0.
rozbb
pushed a commit
to dalek-cryptography/curve25519-dalek
that referenced
this pull request
Dec 28, 2025
rust-random/rand#1697 which updates `rand_core` to v0.10.0-rc-3 for the `rand` crate has been merged. This removes `patch.crates-io` for `getrandom` and pins to the merged commit revision for `rand`, as well as bumping the `getrandom` dependency of `x25519-dalek` to v0.4.0-rc.0.
carloskiki
pushed a commit
to carloskiki/curve25519-dalek
that referenced
this pull request
Jan 3, 2026
Most of the changes in this PR are actually from the associated `rand` crate updates which are happening in rust-random/rand#1697, notably `OsRng` has been renamed to `SysRng` (and is now provided by the `getrandom` crate). We do use some `rand_core` APIs in a few places though, like the STROBE implementation, where this migrates from `rand_core::le` to `rand_core::utils`.
carloskiki
pushed a commit
to carloskiki/curve25519-dalek
that referenced
this pull request
Jan 3, 2026
rust-random/rand#1697 which updates `rand_core` to v0.10.0-rc-3 for the `rand` crate has been merged. This removes `patch.crates-io` for `getrandom` and pins to the merged commit revision for `rand`, as well as bumping the `getrandom` dependency of `x25519-dalek` to v0.4.0-rc.0.
Contributor
|
@dhardy can you cut a new |
Member
Author
|
Done: #1708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Fix the pre-release version of
rand_coresince Cargo does not follow semver rules on pre-releases; this fixes recent CI errors.Update
getrandom; replacerand::rngs::OsRngwithgetrandom::SysRng.Update
rand_coreto0.10.0-rc-3.Motivation
Fix CI and update
rand_core. (I could split into two PRs but there is probably no point.)Details
getrandomandchacha20are both pulled from git since neither has a recent enough release.