Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The recent
rm --purgeaddition introduced a new user-facing flag, but the CLI help contract did not assert that the flag remained discoverable. That left a small regression window where the option could disappear fromrc rm --helpwithout a focused test catching it.This change adds a single help-contract assertion in
crates/cli/tests/help_contract.rssorc rm --helpmust continue to include--purge. The scope stays limited to the recently changedrmsurface and does not alter production behavior.Root Cause
PR #82 added the
--purgeflag to the command implementation, but the help contract forrmstill only checked the older options. The command behavior was tested, while the public discoverability contract for the new flag was not.Validation
This repository does not currently provide a
make pre-committarget, so I ran the equivalent required checks directly:cargo test --test help_contract top_level_command_help_contract -- --exactcargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace